From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49588) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bOwo1-00040f-N2 for qemu-devel@nongnu.org; Sun, 17 Jul 2016 20:53:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bOwnx-0000qm-HZ for qemu-devel@nongnu.org; Sun, 17 Jul 2016 20:53:08 -0400 Date: Mon, 18 Jul 2016 10:45:56 +1000 From: David Gibson Message-ID: <20160718004556.GC16769@voom.fritz.box> References: <1468596130-27783-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="yLVHuoLXiP9kZBkt" Content-Disposition: inline In-Reply-To: <1468596130-27783-1-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH] target-ppc: fix left shift overflow in hpte_page_shift List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, Alexander Graf , "open list:PowerPC" --yLVHuoLXiP9kZBkt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 15, 2016 at 05:22:10PM +0200, Paolo Bonzini wrote: > ps->pte_enc is a 32-bit value, which is shifted left and then compared > to a 64-bit value. It needs a cast before the shift. >=20 > Reported by Coverity. >=20 > Signed-off-by: Paolo Bonzini Applied to ppc-for-2.7, thanks. > --- > target-ppc/mmu-hash64.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/target-ppc/mmu-hash64.c b/target-ppc/mmu-hash64.c > index 82c2186..8f7e5b4 100644 > --- a/target-ppc/mmu-hash64.c > +++ b/target-ppc/mmu-hash64.c > @@ -479,7 +479,7 @@ static unsigned hpte_page_shift(const struct ppc_one_= seg_page_size *sps, > =20 > mask =3D ((1ULL << ps->page_shift) - 1) & HPTE64_R_RPN; > =20 > - if ((pte1 & mask) =3D=3D (ps->pte_enc << HPTE64_R_RPN_SHIFT)) { > + if ((pte1 & mask) =3D=3D ((uint64_t)ps->pte_enc << HPTE64_R_RPN_= SHIFT)) { > return ps->page_shift; > } > } --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --yLVHuoLXiP9kZBkt Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXjCbEAAoJEGw4ysog2bOSDU0P/jF97RijC7/Yhfx5O3M1uZPk VaWFID/eW+UELkzQ2y8TCe4d66W4qlQHNLd/4mFLlZ1BP6PwK4G2PlwtIiCJJyrF 7Q+NXyziNq20BVIL4ogVTE+1vludsHMsHzJRdSxWaScw+8G7dmGBq+yB3Noi013g z9bZBC1FzXj8Emu8V3g9VI3DpQz3gQNhn3sHSA5Yvshe9XxhzhxYRflg5wSVAiBJ uSjKeZxAzaimD6d3qHlHxcjvH+Zvm5U5+PsDxorG3iFpQlZpTSUUK89hpFmsMVp/ vd6u176Ck8HIUz0O1kDMfUO0z+JkS6mQqXwAWR4p7W3IjAxiDa/9OWgL8KLN6F91 OiKRycu8yoekgHRqjQflpBqd6WtXhKMM2BW2NHWLQ3BMg4lUFpLX5J6LK+Mjya3C 7dWwnsq0QUJRZLPuQe2twE31W29xgvQ/i/Uo7jBVCvtx/OeGwmkwRvx/x0rr4fsI 2z+D5tiyfM4VnChDXR/K7cLvhE0T/UZjdD7mUhXxN+Tu4Kft5H3SbtCpxPVn7DPv nAwEvxTnOfxtqzxZ169SAqTMIuZWZwK0rpoLZfZTKUpFYiPJEazewnBkPepR2++f 6plEZ/W9FRFcleCOksVgRjY7wKahUWg9DKfqhpHUxnhElHsk1ffVP3432gUsw82s TqL6K0aGmhfmNfNyJdTR =ShJr -----END PGP SIGNATURE----- --yLVHuoLXiP9kZBkt--