qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Cornelia Huck <cornelia.huck@de.ibm.com>,
	Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PULL v2 52/55] virtio-input: Wrap in vmstate
Date: Tue, 19 Jul 2016 20:55:41 +0300	[thread overview]
Message-ID: <20160719175541.GA501@redhat.com> (raw)
In-Reply-To: <1468950176-31959-1-git-send-email-mst@redhat.com>

From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>

Forcibly convert it to a vmstate wrapper;  proper conversion
comes later.

Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 hw/input/virtio-input.c | 26 ++++++--------------------
 1 file changed, 6 insertions(+), 20 deletions(-)

diff --git a/hw/input/virtio-input.c b/hw/input/virtio-input.c
index edf6990..a87fd68 100644
--- a/hw/input/virtio-input.c
+++ b/hw/input/virtio-input.c
@@ -217,26 +217,14 @@ static void virtio_input_reset(VirtIODevice *vdev)
     }
 }
 
-static void virtio_input_save(QEMUFile *f, void *opaque)
-{
-    VirtIOInput *vinput = opaque;
-    VirtIODevice *vdev = VIRTIO_DEVICE(vinput);
-
-    virtio_save(vdev, f);
-}
-
-static int virtio_input_load(QEMUFile *f, void *opaque, int version_id)
+static int virtio_input_load(QEMUFile *f, void *opaque, size_t size)
 {
     VirtIOInput *vinput = opaque;
     VirtIOInputClass *vic = VIRTIO_INPUT_GET_CLASS(vinput);
     VirtIODevice *vdev = VIRTIO_DEVICE(vinput);
     int ret;
 
-    if (version_id != VIRTIO_INPUT_VM_VERSION) {
-        return -EINVAL;
-    }
-
-    ret = virtio_load(vdev, f, version_id);
+    ret = virtio_load(vdev, f, VIRTIO_INPUT_VM_VERSION);
     if (ret) {
         return ret;
     }
@@ -280,20 +268,14 @@ static void virtio_input_device_realize(DeviceState *dev, Error **errp)
                 vinput->cfg_size);
     vinput->evt = virtio_add_queue(vdev, 64, virtio_input_handle_evt);
     vinput->sts = virtio_add_queue(vdev, 64, virtio_input_handle_sts);
-
-    register_savevm(dev, "virtio-input", -1, VIRTIO_INPUT_VM_VERSION,
-                    virtio_input_save, virtio_input_load, vinput);
 }
 
 static void virtio_input_device_unrealize(DeviceState *dev, Error **errp)
 {
     VirtIOInputClass *vic = VIRTIO_INPUT_GET_CLASS(dev);
     VirtIODevice *vdev = VIRTIO_DEVICE(dev);
-    VirtIOInput *vinput = VIRTIO_INPUT(dev);
     Error *local_err = NULL;
 
-    unregister_savevm(dev, "virtio-input", vinput);
-
     if (vic->unrealize) {
         vic->unrealize(dev, &local_err);
         if (local_err) {
@@ -304,6 +286,9 @@ static void virtio_input_device_unrealize(DeviceState *dev, Error **errp)
     virtio_cleanup(vdev);
 }
 
+VMSTATE_VIRTIO_DEVICE(input, VIRTIO_INPUT_VM_VERSION, virtio_input_load,
+                      virtio_vmstate_save);
+
 static Property virtio_input_properties[] = {
     DEFINE_PROP_STRING("serial", VirtIOInput, serial),
     DEFINE_PROP_END_OF_LIST(),
@@ -315,6 +300,7 @@ static void virtio_input_class_init(ObjectClass *klass, void *data)
     VirtioDeviceClass *vdc = VIRTIO_DEVICE_CLASS(klass);
 
     dc->props          = virtio_input_properties;
+    dc->vmsd           = &vmstate_virtio_input;
     set_bit(DEVICE_CATEGORY_INPUT, dc->categories);
     vdc->realize      = virtio_input_device_realize;
     vdc->unrealize    = virtio_input_device_unrealize;
-- 
MST

  parent reply	other threads:[~2016-07-19 17:55 UTC|newest]

Thread overview: 59+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-19 22:29 [Qemu-devel] [PULL v2 00/55] pc, pci, virtio: new features, cleanups, fixes Michael S. Tsirkin
2016-07-19 17:50 ` [Qemu-devel] [PULL v2 01/55] nvdimm: fix memory leak in error code path Michael S. Tsirkin
2016-07-19 17:50 ` [Qemu-devel] [PULL v2 02/55] tests/prom-env-test: increase the test timeout Michael S. Tsirkin
2016-07-20  0:10   ` David Gibson
2016-07-19 17:50 ` [Qemu-devel] [PULL v2 03/55] hw/alpha: fix PCI bus initialization Michael S. Tsirkin
2016-07-19 17:50 ` [Qemu-devel] [PULL v2 04/55] hw/mips: " Michael S. Tsirkin
2016-07-19 17:50 ` [Qemu-devel] [PULL v2 05/55] hw/apb: " Michael S. Tsirkin
2016-07-19 17:50 ` [Qemu-devel] [PULL v2 06/55] hw/grackle: " Michael S. Tsirkin
2016-07-19 17:50 ` [Qemu-devel] [PULL v2 07/55] hw/prep: realize the PCI root bus as part of the prep init Michael S. Tsirkin
2016-07-19 17:51 ` [Qemu-devel] [PULL v2 08/55] hw/versatile: realize the PCI root bus as part of the versatile init Michael S. Tsirkin
2016-07-19 17:51 ` [Qemu-devel] [PULL v2 09/55] x86-iommu: introduce parent class Michael S. Tsirkin
2016-07-19 17:51 ` [Qemu-devel] [PULL v2 10/55] intel_iommu: rename VTD_PCI_DEVFN_MAX to x86-iommu Michael S. Tsirkin
2016-07-19 17:51 ` [Qemu-devel] [PULL v2 11/55] x86-iommu: provide x86_iommu_get_default Michael S. Tsirkin
2016-07-19 17:51 ` [Qemu-devel] [PULL v2 12/55] x86-iommu: introduce "intremap" property Michael S. Tsirkin
2016-07-19 17:51 ` [Qemu-devel] [PULL v2 13/55] acpi: enable INTR for DMAR report structure Michael S. Tsirkin
2016-07-19 17:51 ` [Qemu-devel] [PULL v2 14/55] intel_iommu: allow queued invalidation for IR Michael S. Tsirkin
2016-07-19 17:51 ` [Qemu-devel] [PULL v2 15/55] intel_iommu: set IR bit for ECAP register Michael S. Tsirkin
2016-07-19 17:51 ` [Qemu-devel] [PULL v2 16/55] acpi: add DMAR scope definition for root IOAPIC Michael S. Tsirkin
2016-07-19 17:51 ` [Qemu-devel] [PULL v2 17/55] intel_iommu: define interrupt remap table addr register Michael S. Tsirkin
2016-07-19 17:52 ` [Qemu-devel] [PULL v2 18/55] intel_iommu: handle interrupt remap enable Michael S. Tsirkin
2016-07-19 17:52 ` [Qemu-devel] [PULL v2 19/55] intel_iommu: define several structs for IOMMU IR Michael S. Tsirkin
2016-07-19 17:52 ` [Qemu-devel] [PULL v2 20/55] intel_iommu: add IR translation faults defines Michael S. Tsirkin
2016-07-19 17:52 ` [Qemu-devel] [PULL v2 21/55] intel_iommu: Add support for PCI MSI remap Michael S. Tsirkin
2016-07-19 17:52 ` [Qemu-devel] [PULL v2 22/55] q35: ioapic: add support for emulated IOAPIC IR Michael S. Tsirkin
2016-07-19 17:52 ` [Qemu-devel] [PULL v2 23/55] ioapic: introduce ioapic_entry_parse() helper Michael S. Tsirkin
2016-07-19 17:52 ` [Qemu-devel] [PULL v2 24/55] intel_iommu: add support for split irqchip Michael S. Tsirkin
2016-07-19 17:52 ` [Qemu-devel] [PULL v2 25/55] x86-iommu: introduce IEC notifiers Michael S. Tsirkin
2016-07-19 17:52 ` [Qemu-devel] [PULL v2 26/55] ioapic: register IOMMU IEC notifier for ioapic Michael S. Tsirkin
2016-07-19 17:53 ` [Qemu-devel] [PULL v2 27/55] intel_iommu: Add support for Extended Interrupt Mode Michael S. Tsirkin
2016-07-19 17:53 ` [Qemu-devel] [PULL v2 28/55] intel_iommu: add SID validation for IR Michael S. Tsirkin
2016-07-19 17:53 ` [Qemu-devel] [PULL v2 29/55] kvm-irqchip: simplify kvm_irqchip_add_msi_route Michael S. Tsirkin
2016-07-19 17:53 ` [Qemu-devel] [PULL v2 30/55] kvm-irqchip: i386: add hook for add/remove virq Michael S. Tsirkin
2016-07-19 17:53 ` [Qemu-devel] [PULL v2 31/55] kvm-irqchip: x86: add msi route notify fn Michael S. Tsirkin
2016-07-19 17:53 ` [Qemu-devel] [PULL v2 32/55] kvm-irqchip: do explicit commit when update irq Michael S. Tsirkin
2016-07-19 17:53 ` [Qemu-devel] [PULL v2 33/55] intel_iommu: support all masks in interrupt entry cache invalidation Michael S. Tsirkin
2016-07-19 17:53 ` [Qemu-devel] [PULL v2 34/55] kvm-all: add trace events for kvm irqchip ops Michael S. Tsirkin
2016-07-19 17:53 ` [Qemu-devel] [PULL v2 35/55] intel_iommu: disallow kernel-irqchip=on with IR Michael S. Tsirkin
2016-07-19 17:54 ` [Qemu-devel] [PULL v2 36/55] virtio: Add typedef for handle_output Michael S. Tsirkin
2016-07-19 17:54 ` [Qemu-devel] [PULL v2 37/55] virtio: Introduce virtio_add_queue_aio Michael S. Tsirkin
2016-07-19 17:54 ` [Qemu-devel] [PULL v2 38/55] virtio-blk: Call virtio_add_queue_aio Michael S. Tsirkin
2016-07-19 17:54 ` [Qemu-devel] [PULL v2 39/55] virtio-scsi: " Michael S. Tsirkin
2016-07-19 17:54 ` [Qemu-devel] [PULL v2 40/55] Revert "mirror: Workaround for unexpected iohandler events during completion" Michael S. Tsirkin
2016-07-19 17:54 ` [Qemu-devel] [PULL v2 41/55] virtio-scsi: Replace HandleOutput typedef Michael S. Tsirkin
2016-07-19 17:54 ` [Qemu-devel] [PULL v2 42/55] virtio-net: Remove old migration version support Michael S. Tsirkin
2016-07-19 17:54 ` [Qemu-devel] [PULL v2 43/55] virtio-serial: " Michael S. Tsirkin
2016-07-19 17:54 ` [Qemu-devel] [PULL v2 44/55] virtio: Migration helper function and macro Michael S. Tsirkin
2016-07-19 17:54 ` [Qemu-devel] [PULL v2 45/55] virtio-scsi: Wrap in vmstate Michael S. Tsirkin
2016-07-19 17:55 ` [Qemu-devel] [PULL v2 46/55] virtio-blk: " Michael S. Tsirkin
2016-07-19 17:55 ` [Qemu-devel] [PULL v2 47/55] virtio-rng: " Michael S. Tsirkin
2016-07-19 17:55 ` [Qemu-devel] [PULL v2 48/55] virtio-balloon: " Michael S. Tsirkin
2016-07-19 17:55 ` [Qemu-devel] [PULL v2 49/55] virtio-net: " Michael S. Tsirkin
2016-07-19 17:55 ` [Qemu-devel] [PULL v2 50/55] virtio-serial: " Michael S. Tsirkin
2016-07-19 17:55 ` [Qemu-devel] [PULL v2 51/55] 9pfs: " Michael S. Tsirkin
2016-07-19 17:55 ` Michael S. Tsirkin [this message]
2016-07-19 17:55 ` [Qemu-devel] [PULL v2 53/55] virtio-gpu: Use migrate_add_blocker for virgl migration blocking Michael S. Tsirkin
2016-07-19 17:55 ` [Qemu-devel] [PULL v2 54/55] virtio-gpu: Wrap in vmstate Michael S. Tsirkin
2016-07-19 17:55 ` [Qemu-devel] [PULL v2 55/55] virtio: Update migration docs Michael S. Tsirkin
2016-07-20 16:01 ` [Qemu-devel] [PULL v2 00/55] pc, pci, virtio: new features, cleanups, fixes Peter Maydell
2016-07-21  6:39   ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160719175541.GA501@redhat.com \
    --to=mst@redhat.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=dgilbert@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).