From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45231) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPa2l-00015V-Ga for qemu-devel@nongnu.org; Tue, 19 Jul 2016 14:47:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPa2h-0005Av-FV for qemu-devel@nongnu.org; Tue, 19 Jul 2016 14:46:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36040) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPa2h-0005Ak-7C for qemu-devel@nongnu.org; Tue, 19 Jul 2016 14:46:55 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4A34A7F095 for ; Tue, 19 Jul 2016 18:46:54 +0000 (UTC) Date: Tue, 19 Jul 2016 14:46:52 -0400 From: Jeff Cody Message-ID: <20160719184652.GA11659@localhost.localdomain> References: <1468947453-5433-1-git-send-email-prasanna.kalever@redhat.com> <1468947453-5433-4-git-send-email-prasanna.kalever@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1468947453-5433-4-git-send-email-prasanna.kalever@redhat.com> Subject: Re: [Qemu-devel] [PATCH v20 3/5] block/gluster: deprecate rdma support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Prasanna Kumar Kalever Cc: qemu-devel@nongnu.org, kwolf@redhat.com, pkrempa@redhat.com, vbellur@redhat.com, armbru@redhat.com, rtalur@redhat.com On Tue, Jul 19, 2016 at 10:27:31PM +0530, Prasanna Kumar Kalever wrote: > gluster volfile server fetch happens through unix and/or tcp, it doesn't > support volfile fetch over rdma, the rdma code may actually mislead, > to make sure things do not break, for now we fallback to tcp when requested > for rdma with a warning. > > If you are wondering how this worked all these days, its the gluster libgfapi > code which handles anything other than unix transport as socket/tcp, sad but > true. > > Also gluster doesn't support ipv6 addresses, removing the ipv6 related > comments/docs section > > Signed-off-by: Prasanna Kumar Kalever > --- > block/gluster.c | 20 ++++++++++++-------- > 1 file changed, 12 insertions(+), 8 deletions(-) > > diff --git a/block/gluster.c b/block/gluster.c > index 40ee852..8a54ad4 100644 > --- a/block/gluster.c > +++ b/block/gluster.c > @@ -12,6 +12,7 @@ > #include "block/block_int.h" > #include "qapi/error.h" > #include "qemu/uri.h" > +#include "qemu/error-report.h" > > #define GLUSTER_OPT_FILENAME "filename" > #define GLUSTER_OPT_DEBUG "debug" > @@ -134,12 +135,10 @@ static int parse_volume_options(GlusterConf *gconf, char *path) > * > * 'transport' specifies the transport type used to connect to gluster > * management daemon (glusterd). Valid transport types are > - * tcp, unix and rdma. If a transport type isn't specified, then tcp > - * type is assumed. > + * tcp, unix. If a transport type isn't specified, then tcp type is assumed. > * > * 'host' specifies the host where the volume file specification for > - * the given volume resides. This can be either hostname, ipv4 address > - * or ipv6 address. ipv6 address needs to be within square brackets [ ]. > + * the given volume resides. This can be either hostname, ipv4 address. > * If transport type is 'unix', then 'host' field should not be specified. > * The 'socket' field needs to be populated with the path to unix domain > * socket. > @@ -158,11 +157,8 @@ static int parse_volume_options(GlusterConf *gconf, char *path) > * file=gluster://1.2.3.4/testvol/a.img > * file=gluster+tcp://1.2.3.4/testvol/a.img > * file=gluster+tcp://1.2.3.4:24007/testvol/dir/a.img > - * file=gluster+tcp://[1:2:3:4:5:6:7:8]/testvol/dir/a.img > - * file=gluster+tcp://[1:2:3:4:5:6:7:8]:24007/testvol/dir/a.img > * file=gluster+tcp://host.domain.com:24007/testvol/dir/a.img > * file=gluster+unix:///testvol/dir/a.img?socket=/tmp/glusterd.socket > - * file=gluster+rdma://1.2.3.4:24007/testvol/a.img > */ > static int qemu_gluster_parseuri(GlusterConf *gconf, const char *filename) > { > @@ -185,7 +181,9 @@ static int qemu_gluster_parseuri(GlusterConf *gconf, const char *filename) > gconf->transport = g_strdup("unix"); > is_unix = true; > } else if (!strcmp(uri->scheme, "gluster+rdma")) { > - gconf->transport = g_strdup("rdma"); > + gconf->transport = g_strdup("tcp"); > + error_report("Warning: rdma feature is not supported falling " > + "back to tcp"); > } else { > ret = -EINVAL; > goto out; > @@ -1048,6 +1046,12 @@ static BlockDriver bdrv_gluster_unix = { > .create_opts = &qemu_gluster_create_opts, > }; > > +/* rdma is deprecated (actually never supported for volfile fetch) > + * lets maintain for the protocol compatibility, to make sure things > + * won't break immediately for now gluster+rdma will fall back to gluster+tcp > + * protocol with Warning > + * TODO: remove gluster+rdma interface support > + */ > static BlockDriver bdrv_gluster_rdma = { > .format_name = "gluster", > .protocol_name = "gluster+rdma", > -- > 2.7.4 > > Modulo Markus's and Eric's comments: Reviewed-by: Jeff Cody (I'll make the comment changes on commit)