From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39798) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPgM7-0001if-5H for qemu-devel@nongnu.org; Tue, 19 Jul 2016 21:31:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPgM1-0005Rj-TP for qemu-devel@nongnu.org; Tue, 19 Jul 2016 21:31:22 -0400 Date: Wed, 20 Jul 2016 11:00:05 +1000 From: David Gibson Message-ID: <20160720010005.GB27358@voom.fritz.box> References: <1468833560-17397-1-git-send-email-david@gibson.dropbear.id.au> <1468833560-17397-2-git-send-email-david@gibson.dropbear.id.au> <20160719115240.o5aivhfq2yktlvf2@andariel.pipo.sk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="TakKZr9L6Hm6aLOc" Content-Disposition: inline In-Reply-To: <20160719115240.o5aivhfq2yktlvf2@andariel.pipo.sk> Subject: Re: [Qemu-devel] [RFC 1/2] spapr: Reverse order of hotpluggable cpus list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Krempa Cc: imammedo@redhat.com, bharata@linux.vnet.ibm.com, groug@kaod.org, qemu-ppc@nongnu.org, abologna@redhat.com, qemu-devel@nongnu.org --TakKZr9L6Hm6aLOc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 19, 2016 at 01:52:40PM +0200, Peter Krempa wrote: > On Mon, Jul 18, 2016 at 19:19:19 +1000, David Gibson wrote: > > The spapr implementation of query-hotpluggable-cpus builds the list of > > hotpluggable cores from the end (most removed from the list head) > > because that's the easiest way with a singly linked list. Because it > > also traverses the possible CPU cores starting from low indexes the > > resulting list has the cpu cores listed in reverse order by core-id. > >=20 > > That's not generally harmful, but it means the output from "info > > hotpluggable-cpus" is a little harder to read than it could be. > >=20 > > Therefore, traverse the cpus in reverse order so that the final list > > ends up in increasing-core-id order. >=20 > To make this interface usable with in-order hotplug the ordering of the > entries should be codified in the schema documentation. (see my response > on the cover letter for justification). I'm not really sure what you mean by this. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --TakKZr9L6Hm6aLOc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXjs0VAAoJEGw4ysog2bOSnY0QAN/Dj68js+rUOMDfTNPa0XZY sOFrnzUY0SYkQ832GOlcUIN1VPa/nZ7jTNPCFdcsu5xS6A7gmGsbfUFLPptWzkj6 /f8qYP2PRKeB4dISasnssHs8MKQYLZyTLHbGVBDMaB/m3YLeOElGF1Se0MwPxJLX ouV5JvicbWIvKgfzaSID/kFE06FhwkV9XkeYzRjzseicUz2qKcAHNkZucMNeOigL 37WxN4ifBsRuf291JBgr7T53ARSWYRKgBCPGW7EfKql817hNqLubVaoDtmpqdF0D OL+9lrpw/6L+tHoF06thK/SUuW5mDrbWPU7R3e7UddRAr919zm+fdB8wKFGofORY FlfoZ946TX5cx5XDR/tQxXGBkk/loDSDTvuoIL6NWnEHZrmkwlE9hUY8t7vkzp0w srllFcxUAnCoVPehCbfEiaY/AnP83KVA1tG+4JWX1t67bDLsdzSzhVExEwcbofXU FbpxK5qPAH5UHpG5NRXBTznaoLBd+3rE6gJyNSVpfa7wcLFFofLwNq1N0EgZGGvk 13WPEHX5ylgPJDO8FVMpNSFG0sXiFuWjzcyME8HSX/MrI7on101/hkLIzavVMClE V1yJIKZe1Vu4zt7kveUsasjfuZ/QILQ4EsNCFbDpQhshuw/L7XqieevpILyqded9 wsK5kn0RqnB+nMhpq2PX =dhMf -----END PGP SIGNATURE----- --TakKZr9L6Hm6aLOc--