From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34075)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1bPpjS-0005om-6i
	for qemu-devel@nongnu.org; Wed, 20 Jul 2016 07:32:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1bPpjQ-0001YT-2P
	for qemu-devel@nongnu.org; Wed, 20 Jul 2016 07:32:05 -0400
Date: Wed, 20 Jul 2016 10:10:23 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20160720091023.GD13233@stefanha-x1.localdomain>
References: <20160719174411.10996-1-fullmanet@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="3Gf/FFewwPeBMqCJ"
Content-Disposition: inline
In-Reply-To: <20160719174411.10996-1-fullmanet@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v4] qemu-img: add the 'dd' subcommand
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Reda Sallahi <fullmanet@gmail.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>, Fam Zheng <famz@redhat.com>


--3Gf/FFewwPeBMqCJ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Jul 19, 2016 at 07:44:11PM +0200, Reda Sallahi wrote:
> This patch adds a basic dd subcommand analogous to dd(1) to qemu-img.
>=20
> For the start, this implements the bs, if, of and count options and requi=
res
> both if and of to be specified (no stdin/stdout if not specified) and doe=
sn't
> support tty, pipes, etc.
>=20
> The image format must be specified with -O for the output if the raw form=
at
> is not the intended one.
>=20
> Two tests are added to test qemu-img dd.
>=20
> Signed-off-by: Reda Sallahi <fullmanet@gmail.com>
> ---
> Changes from v3:
> * Delete an unused (so far) field in DdIo.
>=20
> Changes from v2:
> * Add copyright headers to new files.
>=20
> Changes from v1:
> * Removal of dead code.
> * Fix a memory leak.
> * Complete the cleanup function in the test cases.
>=20
>  qemu-img-cmds.hx                 |   6 +
>  qemu-img.c                       | 361 +++++++++++++++++++++++++++++++++=
+++++-
>  tests/qemu-iotests/158           |  68 ++++++++
>  tests/qemu-iotests/158.out       |  15 ++
>  tests/qemu-iotests/159           |  70 ++++++++
>  tests/qemu-iotests/159.out       |  87 ++++++++++
>  tests/qemu-iotests/common.filter |   9 +
>  tests/qemu-iotests/group         |   2 +
>  8 files changed, 617 insertions(+), 1 deletion(-)
>  create mode 100755 tests/qemu-iotests/158
>  create mode 100644 tests/qemu-iotests/158.out
>  create mode 100755 tests/qemu-iotests/159
>  create mode 100644 tests/qemu-iotests/159.out

Please document the new command in qemu-img.texi.

Stefan

--3Gf/FFewwPeBMqCJ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJXjz//AAoJEJykq7OBq3PIWJYIAKvpdCZU9mZwUX8Wrb9XDUCf
q6musxhvBtwrHwZ/oXw9CrlBhL1VVKZNFxRJNeNXa/0f0DfL27LlYNC8lTlcgSfo
+mEHjzwr2nJayPjGsothXN0pRQL+2ngEtd2l8fJCyMKaJ4i4Ypf8fnAvKWtVXZIb
ApZrA2RE7iPbCcs7t9bxQVtj3fWYSYZ/yT2vRaRD+bc44pwgu64HT3GBWJnECJOc
ydUTepRm05Syucxzu9zsLtEZVtBOZidEoV4gwpsTVXIFWT8AkwQbeyP+1JgSf5pa
248elTU9rk3SGvobjhmYYqkJvaSO17+L62iooImOz6++8BEx5uvVgOkiNkrTOI0=
=X+X6
-----END PGP SIGNATURE-----

--3Gf/FFewwPeBMqCJ--