From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58299) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPxwy-00049X-2w for qemu-devel@nongnu.org; Wed, 20 Jul 2016 16:18:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPxwt-00071I-Pn for qemu-devel@nongnu.org; Wed, 20 Jul 2016 16:18:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35240) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPxwt-000718-6X for qemu-devel@nongnu.org; Wed, 20 Jul 2016 16:18:31 -0400 Date: Wed, 20 Jul 2016 17:18:26 -0300 From: Eduardo Habkost Message-ID: <20160720201826.GH3337@thinpad.lan.raisama.net> References: <146843310345.22044.7846135644864365198.stgit@bahia.lan> <20160714014240.GK14615@voom.fritz.box> <20160714102957.44124e9e@nial.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160714102957.44124e9e@nial.brq.redhat.com> Subject: Re: [Qemu-devel] [PATCH] vl: exit if a bad property value is passed to -global List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: David Gibson , Greg Kurz , Paolo Bonzini , qemu-devel@nongnu.org, Bharata B Rao Sorry for the long delay: On Thu, Jul 14, 2016 at 10:29:57AM +0200, Igor Mammedov wrote: > On Thu, 14 Jul 2016 11:42:40 +1000 > David Gibson wrote: > > > On Wed, Jul 13, 2016 at 08:05:03PM +0200, Greg Kurz wrote: > > > When passing '-global driver=host-powerpc64-cpu,property=compat,value=foo' > > > on the command line, without this patch, we get the following warning per > > > device (which means many lines if the guests has many cpus): > > > > > > qemu-system-ppc64: Warning: can't apply global host-powerpc64-cpu.compat=foo: > > > Invalid compatibility mode "foo" > > > > > > ... and QEMU continues execution, ignoring the property. > > > > > > With this patch, we get a single line: > > > > > > qemu-system-ppc64: can't apply global host-powerpc64-cpu.compat=foo: > > > Invalid compatibility mode "foo" > > > > > > ... and QEMU exits. > > > > > > Signed-off-by: Greg Kurz > > > > Reviewed-by: David Gibson > > > > Not really up to me to decide if this is the right approach for global > > option handling, but it seems like the way to go to me. > CCing Eduardo > as he basically rewrote that path several times and might know why it's this way now. > > > > > > --- > > > vl.c | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/vl.c b/vl.c > > > index 356713ea075c..a7cc92781687 100644 > > > --- a/vl.c > > > +++ b/vl.c > > > @@ -2922,6 +2922,7 @@ static int global_init_func(void *opaque, QemuOpts *opts, Error **errp) > > > g->property = qemu_opt_get(opts, "property"); > > > g->value = qemu_opt_get(opts, "value"); > > > g->user_provided = true; > > > + g->errp = errp; Exiting QEMU like you suggest is valid, but we can't set errp to error_fatal here, because it could make QEMU abort when using device_add. Probably the simplest solution is to ignore GlobalProperty.errp in qdev_prop_set_globals_for_type() if dev->hotplugged is set. Then we can safely set errp here. -- Eduardo