From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44188) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQ9p8-0000w1-2f for qemu-devel@nongnu.org; Thu, 21 Jul 2016 04:59:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQ9p7-0007d0-6V for qemu-devel@nongnu.org; Thu, 21 Jul 2016 04:59:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61187) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQ9p7-0007cw-1M for qemu-devel@nongnu.org; Thu, 21 Jul 2016 04:59:17 -0400 From: marcandre.lureau@redhat.com Date: Thu, 21 Jul 2016 12:57:43 +0400 Message-Id: <20160721085750.30008-25-marcandre.lureau@redhat.com> In-Reply-To: <20160721085750.30008-1-marcandre.lureau@redhat.com> References: <20160721085750.30008-1-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v5 24/31] vhost-user: wait until backend init is completed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: mukawa@igel.co.jp, yuanhan.liu@linux.intel.com, victork@redhat.com, jonshin@cisco.com, mst@redhat.com, =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= From: Marc-Andr=C3=A9 Lureau The chardev waits for an initial connection before starting qemu, and vhost-user should wait for the backend negotiation to be completed before starting qemu too. vhost-user is started in the net_vhost_user_event callback, which is synchronously called after the socket is connected. Use a VhostUserState.started flag to indicate vhost-user init completed successfully and qemu can be started. Signed-off-by: Marc-Andr=C3=A9 Lureau --- net/vhost-user.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/net/vhost-user.c b/net/vhost-user.c index 5e23869..4867944 100644 --- a/net/vhost-user.c +++ b/net/vhost-user.c @@ -23,6 +23,7 @@ typedef struct VhostUserState { CharDriverState *chr; VHostNetState *vhost_net; guint watch; + bool started; } VhostUserState; =20 typedef struct VhostUserChardevProps { @@ -218,6 +219,7 @@ static void net_vhost_user_event(void *opaque, int ev= ent) return; } qmp_set_link(name, true, &err); + s->started =3D true; break; case CHR_EVENT_CLOSED: qmp_set_link(name, false, &err); @@ -236,7 +238,7 @@ static int net_vhost_user_init(NetClientState *peer, = const char *device, const char *name, CharDriverState *chr, int queues) { - NetClientState *nc; + NetClientState *nc, *nc0 =3D NULL; VhostUserState *s; int i; =20 @@ -245,6 +247,9 @@ static int net_vhost_user_init(NetClientState *peer, = const char *device, =20 for (i =3D 0; i < queues; i++) { nc =3D qemu_new_net_client(&net_vhost_user_info, peer, device, n= ame); + if (!nc0) { + nc0 =3D nc; + } =20 snprintf(nc->info_str, sizeof(nc->info_str), "vhost-user%d to %s= ", i, chr->label); @@ -255,7 +260,16 @@ static int net_vhost_user_init(NetClientState *peer,= const char *device, s->chr =3D chr; } =20 - qemu_chr_add_handlers(chr, NULL, NULL, net_vhost_user_event, nc[0].n= ame); + s =3D DO_UPCAST(VhostUserState, nc, nc0); + do { + Error *err =3D NULL; + if (qemu_chr_wait_connected(chr, &err) < 0) { + error_report_err(err); + return -1; + } + qemu_chr_add_handlers(chr, NULL, NULL, + net_vhost_user_event, nc0->name); + } while (!s->started); =20 assert(s->vhost_net); =20 --=20 2.9.0