Re: [Qemu-devel] [PULL v3 00/55] pc, pci, virtio: new features, cleanups, fixes

[Peter Xu <peterx@redhat.com>]

On Thu, Jul 21, 2016 at 10:20:38AM +0100, Peter Maydell wrote:
> On 20 July 2016 at 18:43, Michael S. Tsirkin <mst@redhat.com> wrote:
> > I think that's it feature-wise for 2.7.
> >
> > There are still a couple of bugfix patchsets I plan to merge before -rc1:
> > - vhost-user fixes for backend disconnect
> > - pxb fixes for 64 bit mmio
> > and a couple of other bugfixes here and there.
> >
> >
> > The following changes since commit 5d3217340adcb6c4f0e4af5d2b865331eb2ff63d:
> >
> >   disas: Fix ATTRIBUTE_UNUSED define clash with ALSA headers (2016-07-19 16:40:39 +0100)
> >
> > are available in the git repository at:
> >
> >   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
> >
> > for you to fetch changes up to 7525afc2cac78f1ce016696afd2a233434f59441:
> >
> >   virtio: Update migration docs (2016-07-20 19:31:51 +0300)
> >
> > ----------------------------------------------------------------
> > pc, pci, virtio: new features, cleanups, fixes
> >
> > - interrupt remapping for intel iommus
> > - a bunch of virtio cleanups
> > - fixes all over the place
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> >
> > ----------------------------------------------------------------
> 
> Fails to build:
> 
> /home/petmay01/linaro/qemu-for-merges/hw/i386/intel_iommu.c: In
> function ‘vtd_remap_irq_get’:
> /home/petmay01/linaro/qemu-for-merges/hw/i386/intel_iommu.c:2092:5:
> error: missing braces around initializer [-Werror=missing-braces]
>      VTD_IRTE irte = { 0 };
>      ^
> /home/petmay01/linaro/qemu-for-merges/hw/i386/intel_iommu.c:2092:5:
> error: (near initialization for ‘irte.<anonymous>’)
> [-Werror=missing-braces]

Hi, Peter,

Is this a compiler specific issue? Since this can pass compile test on
my machine (both local build, or make docker-test). Do you have any
suggestion on how we can avoid this kind of errors in the future?

Thanks!

-- peterx