From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38067)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1bQBLM-0003wW-1c
	for qemu-devel@nongnu.org; Thu, 21 Jul 2016 06:36:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1bQBLJ-0003vf-01
	for qemu-devel@nongnu.org; Thu, 21 Jul 2016 06:36:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34698)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1bQBLI-0003vb-RO
	for qemu-devel@nongnu.org; Thu, 21 Jul 2016 06:36:36 -0400
Date: Thu, 21 Jul 2016 18:36:32 +0800
From: Peter Xu <peterx@redhat.com>
Message-ID: <20160721103632.GF32544@pxdev.xzpeter.org>
References: <1469036440-4562-1-git-send-email-mst@redhat.com>
	<CAFEAcA_Figok1_GUquLFP7ujBOAbDV_kLuuPhXZzKvYA8c26Bw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAFEAcA_Figok1_GUquLFP7ujBOAbDV_kLuuPhXZzKvYA8c26Bw@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PULL v3 00/55] pc, pci, virtio: new features,
 cleanups, fixes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Michael S. Tsirkin" <mst@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>

On Thu, Jul 21, 2016 at 10:20:38AM +0100, Peter Maydell wrote:
> On 20 July 2016 at 18:43, Michael S. Tsirkin <mst@redhat.com> wrote:
> > I think that's it feature-wise for 2.7.
> >
> > There are still a couple of bugfix patchsets I plan to merge before -=
rc1:
> > - vhost-user fixes for backend disconnect
> > - pxb fixes for 64 bit mmio
> > and a couple of other bugfixes here and there.
> >
> >
> > The following changes since commit 5d3217340adcb6c4f0e4af5d2b865331eb=
2ff63d:
> >
> >   disas: Fix ATTRIBUTE_UNUSED define clash with ALSA headers (2016-07=
-19 16:40:39 +0100)
> >
> > are available in the git repository at:
> >
> >   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstrea=
m
> >
> > for you to fetch changes up to 7525afc2cac78f1ce016696afd2a233434f594=
41:
> >
> >   virtio: Update migration docs (2016-07-20 19:31:51 +0300)
> >
> > ----------------------------------------------------------------
> > pc, pci, virtio: new features, cleanups, fixes
> >
> > - interrupt remapping for intel iommus
> > - a bunch of virtio cleanups
> > - fixes all over the place
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> >
> > ----------------------------------------------------------------
>=20
> Fails to build:
>=20
> /home/petmay01/linaro/qemu-for-merges/hw/i386/intel_iommu.c: In
> function =E2=80=98vtd_remap_irq_get=E2=80=99:
> /home/petmay01/linaro/qemu-for-merges/hw/i386/intel_iommu.c:2092:5:
> error: missing braces around initializer [-Werror=3Dmissing-braces]
>      VTD_IRTE irte =3D { 0 };
>      ^
> /home/petmay01/linaro/qemu-for-merges/hw/i386/intel_iommu.c:2092:5:
> error: (near initialization for =E2=80=98irte.<anonymous>=E2=80=99)
> [-Werror=3Dmissing-braces]

Hi, Peter,

Is this a compiler specific issue? Since this can pass compile test on
my machine (both local build, or make docker-test). Do you have any
suggestion on how we can avoid this kind of errors in the future?

Thanks!

-- peterx