From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60192) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQG4w-0003PR-9Q for qemu-devel@nongnu.org; Thu, 21 Jul 2016 11:40:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQG4s-00040h-2w for qemu-devel@nongnu.org; Thu, 21 Jul 2016 11:40:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43038) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQG4r-00040c-Te for qemu-devel@nongnu.org; Thu, 21 Jul 2016 11:39:58 -0400 Date: Thu, 21 Jul 2016 16:39:53 +0100 From: "Daniel P. Berrange" Message-ID: <20160721153953.GJ13528@redhat.com> Reply-To: "Daniel P. Berrange" References: <1469097213-26441-1-git-send-email-caoj.fnst@cn.fujitsu.com> <1469097213-26441-3-git-send-email-caoj.fnst@cn.fujitsu.com> <5790DF51.8030806@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5790DF51.8030806@redhat.com> Subject: Re: [Qemu-devel] [PATCH 2/2] util/qemu-sockets: shoot unix_nonblocking_connect() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Cao jin , qemu-devel@nongnu.org, Paolo Bonzini , Gerd Hoffmann On Thu, Jul 21, 2016 at 08:42:25AM -0600, Eric Blake wrote: > On 07/21/2016 04:33 AM, Cao jin wrote: > > It is never used, and now all connect is nonblocking via > > inet_connect_addr(). > > > > Could be squashed with 1/2. In fact, if you squash it, I'd title the patch: > > util: Drop unused *_nonblocking_connect() functions > > You may also want to call out which commit id rendered the functions unused. Well once those two functions are dropped the only other place accepting NonBlockingConnectHandler is the socket_connect() method. Since nearly everything is converted to QIOChannel now, there's only one caller of socket_connect() left, and that's net/socket.c Any newly written code which needs a non-blocking connect should use the QIOChannel code, so I don't see any further usage of socket_connect() being added. IOW, we can rip out NonBlockingConnectHandler as a concept entirely, not merely drop the *_nonblocking_connect() methods. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|