From: Aurelien Jarno <aurelien@aurel32.net>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Patch Tracking <patches@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] target-sh4: Use glib allocator in movcal helper
Date: Thu, 21 Jul 2016 18:28:34 +0200 [thread overview]
Message-ID: <20160721162834.GA23477@aurel32.net> (raw)
In-Reply-To: <CAFEAcA_p9TiXpcKLqKaD1PCR_gV_G+o=GFwfLQT02R+FpYOXRQ@mail.gmail.com>
On 2016-07-21 13:44, Peter Maydell wrote:
> Ping?
>
> thanks
> -- PMM
>
> On 12 July 2016 at 13:50, Peter Maydell <peter.maydell@linaro.org> wrote:
> > Coverity spots that helper_movcal() calls malloc() but doesn't
> > check for failure. Fix this by switching to the glib allocation
> > functions, which abort on allocation failure.
> >
> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> > ---
> > target-sh4/op_helper.c | 7 ++++---
> > 1 file changed, 4 insertions(+), 3 deletions(-)
I have just looked at it and test it. It's all fine, sorry for the
delay.
Acked-by: Aurelien Jarno <aurelien@aurel32.net>
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net
next prev parent reply other threads:[~2016-07-21 16:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 12:50 [Qemu-devel] [PATCH] target-sh4: Use glib allocator in movcal helper Peter Maydell
2016-07-21 12:44 ` Peter Maydell
2016-07-21 16:28 ` Aurelien Jarno [this message]
2016-07-22 11:06 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160721162834.GA23477@aurel32.net \
--to=aurelien@aurel32.net \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).