From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46560) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQGqM-0003Jq-IF for qemu-devel@nongnu.org; Thu, 21 Jul 2016 12:29:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQGqK-0008Pj-Fw for qemu-devel@nongnu.org; Thu, 21 Jul 2016 12:29:01 -0400 Received: from hall.aurel32.net ([2001:bc8:30d7:100::1]:46152) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQGqK-0008ON-9H for qemu-devel@nongnu.org; Thu, 21 Jul 2016 12:29:00 -0400 Date: Thu, 21 Jul 2016 18:28:34 +0200 From: Aurelien Jarno Message-ID: <20160721162834.GA23477@aurel32.net> References: <1468327859-21385-1-git-send-email-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] target-sh4: Use glib allocator in movcal helper List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers , Patch Tracking On 2016-07-21 13:44, Peter Maydell wrote: > Ping? > > thanks > -- PMM > > On 12 July 2016 at 13:50, Peter Maydell wrote: > > Coverity spots that helper_movcal() calls malloc() but doesn't > > check for failure. Fix this by switching to the glib allocation > > functions, which abort on allocation failure. > > > > Signed-off-by: Peter Maydell > > --- > > target-sh4/op_helper.c | 7 ++++--- > > 1 file changed, 4 insertions(+), 3 deletions(-) I have just looked at it and test it. It's all fine, sorry for the delay. Acked-by: Aurelien Jarno -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net