From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57908) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQNFm-0008FZ-7W for qemu-devel@nongnu.org; Thu, 21 Jul 2016 19:19:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQNFi-0007UQ-5Z for qemu-devel@nongnu.org; Thu, 21 Jul 2016 19:19:42 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:46166) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQNFh-0007UK-Sa for qemu-devel@nongnu.org; Thu, 21 Jul 2016 19:19:38 -0400 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u6LNJ96I093975 for ; Thu, 21 Jul 2016 19:19:37 -0400 Received: from e19.ny.us.ibm.com (e19.ny.us.ibm.com [129.33.205.209]) by mx0a-001b2d01.pphosted.com with ESMTP id 24athdda0d-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Thu, 21 Jul 2016 19:19:36 -0400 Received: from localhost by e19.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 21 Jul 2016 19:19:35 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: <20160630190415.6192.5429@loki> References: <1465572354-3083-1-git-send-email-thuth@redhat.com> <20160630190415.6192.5429@loki> Date: Thu, 21 Jul 2016 18:19:28 -0500 Message-Id: <20160721231928.496.84486@loki> Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Rename CONFIG_QGA_NTDDDISK into CONFIG_QGA_NTDDSCSI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org Quoting Michael Roth (2016-06-30 14:04:15) > Quoting Thomas Huth (2016-06-10 10:25:54) > > There is no CONFIG_QGA_NTDDDISK define used anywhere in the QEMU > > sources. Looking at the changelog and qga/commands-win32.c, it > > seems like this should be called CONFIG_QGA_NTDDSCSI instead. > > = > > Signed-off-by: Thomas Huth > = > Thanks, applied to qga tree: > https://github.com/mdroth/qemu/commits/qga > = > Although this did indeed uncover a bug in guest-get-fsinfo. > Should have a fix soon, but will want that in place before > I send a pull. So, that fix turned into a fairly heavy rework of how we map PCI devices to filesystems in the current w32 implementation of guest-get-fsinfo and I still don't quite have it working. It probably won't make 2.7 at this point. Unfortunately, as things stand, enabling the disk info support on w32 via your patch causes the entire command to fail, which would be a regression from the current support level. So for now I think the most expedient thing to do would be to hold off on this patch till 2.8, at which point we can apply it along with the disk info fixes I'm working on. > = > > --- > > configure | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > = > > diff --git a/configure b/configure > > index 8c2f90b..55019d6 100755 > > --- a/configure > > +++ b/configure > > @@ -4965,7 +4965,7 @@ if test "$mingw32" =3D "yes" ; then > > echo "WIN_SDK=3D\"$win_sdk\"" >> $config_host_mak > > fi > > if test "$guest_agent_ntddscsi" =3D "yes" ; then > > - echo "CONFIG_QGA_NTDDDISK=3Dy" >> $config_host_mak > > + echo "CONFIG_QGA_NTDDSCSI=3Dy" >> $config_host_mak > > fi > > if test "$guest_agent_msi" =3D "yes"; then > > echo "QEMU_GA_MSI_ENABLED=3Dyes" >> $config_host_mak = > > -- = > > 1.8.3.1 > > = > = >=20