From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37784) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQLw9-0004B8-MK for qemu-devel@nongnu.org; Thu, 21 Jul 2016 17:55:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQLw5-0005T8-Vi for qemu-devel@nongnu.org; Thu, 21 Jul 2016 17:55:20 -0400 Received: from 8.mo178.mail-out.ovh.net ([46.105.74.227]:47905) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQLw5-0005RQ-Oj for qemu-devel@nongnu.org; Thu, 21 Jul 2016 17:55:17 -0400 Received: from player169.ha.ovh.net (b9.ovh.net [213.186.33.59]) by mo178.mail-out.ovh.net (Postfix) with ESMTP id 290AD1004216 for ; Thu, 21 Jul 2016 23:55:16 +0200 (CEST) Date: Thu, 21 Jul 2016 23:55:09 +0200 From: Greg Kurz Message-ID: <20160721235509.06d897cb@bahia.lan> In-Reply-To: <146913602256.26732.547184422534259409.stgit@bahia.lan> References: <146913602256.26732.547184422534259409.stgit@bahia.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4] virtio-pci: error out when both legacy and modern modes are disabled List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum Cc: Cornelia Huck , qemu-devel@nongnu.org, "Michael S. Tsirkin" On Thu, 21 Jul 2016 23:21:16 +0200 Greg Kurz wrote: > From: Greg Kurz > > Without presuming if we got there because of a user mistake or some > more subtle bug in the tooling, it really does not make sense to > implement a non-functional device. > > Signed-off-by: Greg Kurz > Reviewed-by: Marcel Apfelbaum > Signed-off-by: Greg Kurz > --- > v4: - rephrased error message and provide a hint to the user > - split string literals to stay below 80 characters > - added Marcel's R-b tag > --- Marcel, I see that Michael has comments on your patch. If you feel this patch is valuable for 2.7, please consider carrying and pushing it, as I'm about to take a 1-month leave. Thanks. -- Greg > hw/virtio/virtio-pci.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c > index 755f9218b77d..72c4b392ffda 100644 > --- a/hw/virtio/virtio-pci.c > +++ b/hw/virtio/virtio-pci.c > @@ -1842,6 +1842,14 @@ static void virtio_pci_dc_realize(DeviceState *qdev, Error **errp) > VirtIOPCIProxy *proxy = VIRTIO_PCI(qdev); > PCIDevice *pci_dev = &proxy->pci_dev; > > + if (!(virtio_pci_modern(proxy) || virtio_pci_legacy(proxy))) { > + error_setg(errp, "device cannot work when both modern and legacy modes" > + " are disabled"); > + error_append_hint(errp, "Set either disable-modern or disable-legacy" > + " to off\n"); > + return; > + } > + > if (!(proxy->flags & VIRTIO_PCI_FLAG_DISABLE_PCIE) && > virtio_pci_modern(proxy)) { > pci_dev->cap_present |= QEMU_PCI_CAP_EXPRESS; > >