From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51840)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bQP27-000311-Ns
	for qemu-devel@nongnu.org; Thu, 21 Jul 2016 21:13:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bQP24-0005rn-Ex
	for qemu-devel@nongnu.org; Thu, 21 Jul 2016 21:13:43 -0400
Received: from mx1.redhat.com ([209.132.183.28]:35218)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bQP24-0005qu-96
	for qemu-devel@nongnu.org; Thu, 21 Jul 2016 21:13:40 -0400
Date: Fri, 22 Jul 2016 09:13:37 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20160722011337.GA21282@ad.usersys.redhat.com>
References: <1469036440-4562-1-git-send-email-mst@redhat.com>
	<CAFEAcA_Figok1_GUquLFP7ujBOAbDV_kLuuPhXZzKvYA8c26Bw@mail.gmail.com>
	<20160721103632.GF32544@pxdev.xzpeter.org>
	<CAFEAcA-YSJEuCpGngOBvwNV2o9DK28b8xGmr5XoJ8gv2H+r1gg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAFEAcA-YSJEuCpGngOBvwNV2o9DK28b8xGmr5XoJ8gv2H+r1gg@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PULL v3 00/55] pc, pci, virtio: new features,
 cleanups, fixes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Peter Xu <peterx@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>, "Michael S. Tsirkin" <mst@redhat.com>

On Thu, 07/21 11:45, Peter Maydell wrote:
> On 21 July 2016 at 11:36, Peter Xu <peterx@redhat.com> wrote:
> > On Thu, Jul 21, 2016 at 10:20:38AM +0100, Peter Maydell wrote:
> >> Fails to build:
> >>
> >> /home/petmay01/linaro/qemu-for-merges/hw/i386/intel_iommu.c: In
> >> function =E2=80=98vtd_remap_irq_get=E2=80=99:
> >> /home/petmay01/linaro/qemu-for-merges/hw/i386/intel_iommu.c:2092:5:
> >> error: missing braces around initializer [-Werror=3Dmissing-braces]
> >>      VTD_IRTE irte =3D { 0 };
> >>      ^
> >> /home/petmay01/linaro/qemu-for-merges/hw/i386/intel_iommu.c:2092:5:
> >> error: (near initialization for =E2=80=98irte.<anonymous>=E2=80=99)
> >> [-Werror=3Dmissing-braces]
>=20
> > Is this a compiler specific issue? Since this can pass compile test o=
n
> > my machine (both local build, or make docker-test). Do you have any
> > suggestion on how we can avoid this kind of errors in the future?
>=20
> It failed on several of my test builds, not just one, but these
> things are tricky to avoid if they don't happen on all compilers.
> In this case I think it is a compiler bug:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D53119
> so you'll only see it with an older compiler.

Could you name the distro and gcc version? If it's worth to keep the bugg=
y
compiler happy, it probably can be added as a docker test. :)

Fam