From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44983) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQMLI-0004M9-QS for qemu-devel@nongnu.org; Thu, 21 Jul 2016 18:21:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQMLF-0003Np-K5 for qemu-devel@nongnu.org; Thu, 21 Jul 2016 18:21:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51780) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQMLF-0003Ne-ET for qemu-devel@nongnu.org; Thu, 21 Jul 2016 18:21:17 -0400 Date: Fri, 22 Jul 2016 01:21:13 +0300 From: "Michael S. Tsirkin" Message-ID: <20160722012006-mutt-send-email-mst@kernel.org> References: <1469028501-23780-1-git-send-email-marcel@redhat.com> <20160722003618-mutt-send-email-mst@kernel.org> <1469138332.3363.66.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1469138332.3363.66.camel@redhat.com> Subject: Re: [Qemu-devel] [PATCH V3] hw/virtio-pci: fix virtio behaviour List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Marcel Apfelbaum , qemu-devel@nongnu.org, cornelia.huck@de.ibm.com On Thu, Jul 21, 2016 at 11:58:52PM +0200, Gerd Hoffmann wrote: > Hi, > > > Actually this can still break existing scripts: > > stick a device on express bus but add disable-modern=on > > Gave you a legacy device previously but it no longer does. > > Unlikely to happen in practice because there is little reason to use > disable-modern=on in 2.6 & older because that is the default ... Good point, I forgot. > Still we can default to legacy=yes in case disable-modern=on + > disable-legacy=auto. Given the above I'm not sure it's worth it. I'll leave it to Marcel to decide. > And throw and error in case both modern and legacy > are explicitly disabled (as already suggested elsewhere in this thread). > > cheers, > Gerd