From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48379) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQSHU-0002pb-M4 for qemu-devel@nongnu.org; Fri, 22 Jul 2016 00:41:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQSHQ-0001wk-Fo for qemu-devel@nongnu.org; Fri, 22 Jul 2016 00:41:47 -0400 Date: Fri, 22 Jul 2016 14:35:05 +1000 From: David Gibson Message-ID: <20160722043505.GN15941@voom.fritz.box> References: <1469116479-233280-1-git-send-email-imammedo@redhat.com> <20160722005535-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="citGix+cyBYE+lqp" Content-Disposition: inline In-Reply-To: <20160722005535-mutt-send-email-mst@kernel.org> Subject: Re: [Qemu-devel] [PATCH 0/8] Fix migration issues with arbitrary cpu-hot(un)plug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Igor Mammedov , qemu-devel@nongnu.org, Paolo Bonzini , Peter Crosthwaite , Richard Henderson , Eduardo Habkost , Alexander Graf , Riku Voipio , Bharata B Rao , qemu-ppc@nongnu.org --citGix+cyBYE+lqp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 22, 2016 at 12:56:26AM +0300, Michael S. Tsirkin wrote: > On Thu, Jul 21, 2016 at 05:54:31PM +0200, Igor Mammedov wrote: > > Series fixes migration issues caused by unstable cpu_index which depend= ed > > on order cpus were created/destroyed. It follows David's idea to make > > cpu_index assignable by selected boards if board supports cpu-hotplug > > with device_add and needs stable cpu_index/'migration id' but leaves > > behaviour of the same as before for users that don't care about > > cpu-hot(un)plug making changes low-risk. > >=20 > > tested with: > > SRC -snapshot -enable-kvm -smp 1,maxcpus=3D3 -m 256M guest.img -monit= or stdio \ > > -device qemu64-x86_64-cpu,id=3Dcpudel,apic-id=3D1 \ > > -device qemu64-x86_64-cpu,apic-id=3D2=20 > > (qemu) device_del cpudel > > (qemu) stop > > (qemu) migrate "exec:gzip -c > STATEFILE.gz" > > =20 > > DST -snapshot -enable-kvm -smp 1,maxcpus=3D3 -m 256M guest.img -monit= or stdio \ > > -device qemu64-x86_64-cpu,apic-id=3D2 \ > > -incoming "exec: gzip -c -d STATEFILE.gz" > >=20 > > git tree to test with: > > https://github.com/imammedo/qemu cpu-index-stable > > to view > > https://github.com/imammedo/qemu/commits/cpu-index-stable >=20 > For PC bits: >=20 > Reviewed-by: Michael S. Tsirkin >=20 > This would be nice to have in 2.7. I agree. Despite the lateness, I think this will avoid substantial future pain. > Who's reviewing/merging the rest? Eduardo? I've reviewed. I could merge through my tree if we don't have a better option, but merging pc specific pieces through the ppc tree would seem odd. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --citGix+cyBYE+lqp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXkaJ5AAoJEGw4ysog2bOS6vIQAKnArU/RNtqCNdWpOByLaEpZ mvt04zIFrducHs2EV+eNDrJmeKx3jfCqkBeTPWF8BNe1pAy7P9Eq9+qliP1uu25T BXITx1HpuTlfnBX1iS2KH/SYitF8/P47QzGY9jdIoxcsgX0z97ksd7PDdRCynxij u6Cx78hM1oDji7Hh9taEH5mKkN4BE0Zxud0LiMrWWR8HYswIm4UT18EqSNeNQcB8 d9AozxMOj4c9OudNfOYK1oGHe9Amc8ZdU/NIl4B2i2k7CEN3LnlckHyr7NN++/Q8 w602DSPCshK3pxnICgy6+Gg1VM+sHXqDfIkIn//rhdvW8Ou6xMCJrSEalHXNoPnz 5wAUPwNKU2haMsCgPy01W8KXmbUWhq3x4IG38sExv0OTjdiTjZLRBJ2fr63gkGaA Ukv9jpruMh70/ih28eESe6kf4PVLzuSQkGpkpTHfVsOu0jG0Tm1/UnU4f6ooiaZa OkylFkLtCy2nOeMnGa4kYfLoIjKnqigsxAW8Czr3/R8FmjToOw1l5Dt5NFge3ETP lyG3KZROqNvkxJhRDZEVp6LV8z9t0obprTlNHCqXcaWa2pAIiYgF6ayoWQjOPHk/ qUrgufg4ujKQxrI2SkZLUj4fIQJ/4My2x2gAm44v8keplwefUo2r+gkbgTRBZUM7 ux2MSXKvTUusiiHd49OC =HhcU -----END PGP SIGNATURE----- --citGix+cyBYE+lqp--