From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52103) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bQSgI-0001RC-AA for qemu-devel@nongnu.org; Fri, 22 Jul 2016 01:07:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bQSgG-0006nq-3h for qemu-devel@nongnu.org; Fri, 22 Jul 2016 01:07:25 -0400 Date: Fri, 22 Jul 2016 14:59:20 +1000 From: David Gibson Message-ID: <20160722045920.GQ15941@voom.fritz.box> References: <1468861517-2508-1-git-send-email-nikunj@linux.vnet.ibm.com> <1468861517-2508-11-git-send-email-nikunj@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="+r+clu82y77Ss1pj" Content-Disposition: inline In-Reply-To: <1468861517-2508-11-git-send-email-nikunj@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [RFC v1 10/13] target-ppc: add setb instruction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikunj A Dadhania Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, aneesh.kumar@linux.vnet.ibm.com, benh@kernel.crashing.org, Vivek Andrew Sha --+r+clu82y77Ss1pj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 18, 2016 at 10:35:14PM +0530, Nikunj A Dadhania wrote: > From: Vivek Andrew Sha >=20 > Returns: > -1 if bit 0 of CR field is set > 0 if bit 1 of CR field is set > 1 otherwise. Um.. that description is pretty inadequate. Retuns where? Which CR field? > Signed-off-by: Vivek Andrew Sha > [ reworded commit, used 32bit ops as crf is 32bits ] > Signed-off-by: Nikunj A Dadhania > --- > target-ppc/translate.c | 30 ++++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) >=20 > diff --git a/target-ppc/translate.c b/target-ppc/translate.c > index 8f7ff49..9464942 100644 > --- a/target-ppc/translate.c > +++ b/target-ppc/translate.c > @@ -4879,6 +4879,35 @@ static void gen_mtspr(DisasContext *ctx) > } > } > =20 > +#if defined(TARGET_PPC64) > +/* setb */ > +static void gen_setb(DisasContext *ctx) > +{ > + TCGLabel *l1 =3D gen_new_label(); > + TCGLabel *l2 =3D gen_new_label(); > + TCGLabel *out =3D gen_new_label(); > + TCGv_i32 t0 =3D tcg_temp_local_new_i32(); > + TCGv_i64 ret =3D tcg_temp_local_new_i64(); > + int crf =3D crfS(ctx->opcode); > + > + tcg_gen_andi_i32(t0, cpu_crf[crf], 0x3); > + tcg_gen_brcondi_i32(TCG_COND_EQ, t0, 0, l1); > + tcg_gen_andi_i32(t0, cpu_crf[crf], 0x1); > + tcg_gen_brcondi_i32(TCG_COND_EQ, t0, 1, l2); > + tcg_gen_movi_i64(cpu_gpr[rD(ctx->opcode)], 1); > + tcg_gen_br(out); > + gen_set_label(l2); > + tcg_gen_movi_i64(cpu_gpr[rD(ctx->opcode)], -1); > + tcg_gen_br(out); > + gen_set_label(l1); > + tcg_gen_movi_i64(cpu_gpr[rD(ctx->opcode)], 0); > + gen_set_label(out); > + > + tcg_temp_free_i32(t0); > + tcg_temp_free_i64(ret); > +} > +#endif > + > /*** Cache management = ***/ > =20 > /* dcbf */ > @@ -10195,6 +10224,7 @@ GEN_HANDLER(mftb, 0x1F, 0x13, 0x0B, 0x00000001, P= PC_MFTB), > GEN_HANDLER(mtcrf, 0x1F, 0x10, 0x04, 0x00000801, PPC_MISC), > #if defined(TARGET_PPC64) > GEN_HANDLER(mtmsrd, 0x1F, 0x12, 0x05, 0x001EF801, PPC_64B), > +GEN_HANDLER_E(setb, 0x1F, 0x00, 0x04, 0x0003F801, PPC_NONE, PPC2_ISA300), > #endif > GEN_HANDLER(mtmsr, 0x1F, 0x12, 0x04, 0x001EF801, PPC_MISC), > GEN_HANDLER(mtspr, 0x1F, 0x13, 0x0E, 0x00000000, PPC_MISC), --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --+r+clu82y77Ss1pj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXkagoAAoJEGw4ysog2bOSgkQQAMTBVHLdHlK1LUhlEkKisn/b 0YDcBi1KABSUhf1H1uawVKbrWGrWAn1813bqqMFh24aa3vnSskuRyknnAeU9Yk0Z UmD1QDKW108K5tJXFZXm9MvEQE4+DraCzUaTyn2PEDOx8QeVFwVaf1ZV+5J7jfBC obhs7x/6s1mEvNElFWr9+aVIDMeamuRDeTyWYQ1I64M0Q8TVHEOKqAxwQgrT9Ch1 b7AMFXprYGiXxgFbfBO8zEUfW5TGyNbjk7PmpvlmkwBIl7iMaQ4o7DHDYkNQHqlg qpNEhay66ygRdCCnQe78UuaPVX/c9bXyAFjEjiD71jwLA/vuBCVj6t00sQAB5FhP lLlHsqAXn6lLjTdHiu6L5cnuMwscarHCMiIj1wHfUydGnk8rDCy3XnFcmYCIL7La 2v4ymsqYOkBXtb1KOyFAgNZk/CkmJ/XIIOO0iI8bE5GcZrxdJftN4vaO6Zk0Nus8 RwCB2sDIYT5s1QANj1JZbH8i3CB4Vd2flmvzMJy54RMVXg4WthlETU1mArh+x0cW Dl0JttHG0p+a5myTruektSIzxlrHSQA+bZd4agv74bMc1raossXaziw0kprSCVah fibWy8YUMVpaQw86KAn1kkqSkt7PDMIscd9ZXYZXSFzAUf6q5aiJCbxEB7vhK9qs hVgTynIElX5QWz0FjEF5 =xFFg -----END PGP SIGNATURE----- --+r+clu82y77Ss1pj--