qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: zhanghailiang <zhang.zhanghailiang@huawei.com>,
	qemu-devel@nongnu.org, amit.shah@redhat.com,
	peter.huangpeng@huawei.com, quintela@redhat.com
Subject: Re: [Qemu-devel] [RFC PATCH 0/2] Migration: support working on file:url
Date: Fri, 22 Jul 2016 09:04:34 +0100	[thread overview]
Message-ID: <20160722080433.GB20567@redhat.com> (raw)
In-Reply-To: <20160721174122.GM2195@work-vm>

On Thu, Jul 21, 2016 at 06:41:23PM +0100, Dr. David Alan Gilbert wrote:
> * Daniel P. Berrange (berrange@redhat.com) wrote:
> > On Thu, Jul 21, 2016 at 01:05:58PM +0800, zhanghailiang wrote:
> > > It is more simple to use file:url to migrate VM into file.
> > > Besides, it will be used in memory snapshot.
> > 
> > NB, you can already migrate into a file
> > 
> >    "exec:/bin/cat > /path/to/file"
> > 
> > and likewise
> > 
> >   qemu -incoming "exec:/bin/cat /path/to/file"
> > 
> > This avoids the problem with POSIX I/O on plain files not actually
> > supporting O_NONBLOCK in any sensible manner, which your file:
> > suggestion suffers from.
> 
> Hmm that's a shame; I liked this idea as a nice simplification of the
> exec: stuff.

The only way to achieve that would be to spawn a thread in QEMU that
does I/O to the actual file, and then have the migration code do I/O
to/from that thread via a pipe. IOW, the thread would take the role
of cat.  What that's worth doing or not I don't know, given that it
is already possible to use exec+cat.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

  reply	other threads:[~2016-07-22  8:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-21  5:05 [Qemu-devel] [RFC PATCH 0/2] Migration: support working on file:url zhanghailiang
2016-07-21  5:05 ` [Qemu-devel] [RFC PATCH 1/2] migration: Allow the migrate command to work on file:urls zhanghailiang
2016-07-21 12:05   ` Dr. David Alan Gilbert
2016-07-21 12:13   ` Daniel P. Berrange
2016-07-21  5:06 ` [Qemu-devel] [RFC PATCH 2/2] migration: Allow -incoming to work on file: urls zhanghailiang
2016-07-21 12:07   ` Dr. David Alan Gilbert
2016-07-21 12:19 ` [Qemu-devel] [RFC PATCH 0/2] Migration: support working on file:url Daniel P. Berrange
2016-07-21 17:41   ` Dr. David Alan Gilbert
2016-07-22  8:04     ` Daniel P. Berrange [this message]
2016-07-22  6:28   ` Hailiang Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160722080433.GB20567@redhat.com \
    --to=berrange@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=peter.huangpeng@huawei.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=zhang.zhanghailiang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).