From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36186)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1bQe4w-0003wo-Ft
	for qemu-devel@nongnu.org; Fri, 22 Jul 2016 13:17:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1bQe4s-0002vq-5K
	for qemu-devel@nongnu.org; Fri, 22 Jul 2016 13:17:38 -0400
Received: from mx1.redhat.com ([209.132.183.28]:51719)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1bQe4r-0002vh-Vo
	for qemu-devel@nongnu.org; Fri, 22 Jul 2016 13:17:34 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id F37EBC04D291
	for <qemu-devel@nongnu.org>; Fri, 22 Jul 2016 17:17:32 +0000 (UTC)
Date: Fri, 22 Jul 2016 13:17:30 -0400
From: Jeff Cody <jcody@redhat.com>
Message-ID: <20160722171730.GA19570@localhost.localdomain>
References: <1469198048-8535-1-git-send-email-prasanna.kalever@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1469198048-8535-1-git-send-email-prasanna.kalever@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] block/gluster: fix doc in the qapi
 schema and member name
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com, eblake@redhat.com

On Fri, Jul 22, 2016 at 08:04:08PM +0530, Prasanna Kumar Kalever wrote:
> 1. qapi @BlockdevOptionsGluster schema member name s/debug_level/debug-level/
> 2. rearrange the versioning
> 3. s/server description/servers description/
> 
> Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
> v2: address review comments given by Eric Blake
> v1: Initial patch
> ---
>  qapi/block-core.json | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index f462345..cd14e57 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -1688,9 +1688,9 @@
>  # Drivers that are supported in block device operations.
>  #
>  # @host_device, @host_cdrom: Since 2.1
> +# @gluster: Since 2.7
>  #
>  # Since: 2.0
> -# @gluster: Since 2.7
>  ##
>  { 'enum': 'BlockdevDriver',
>    'data': [ 'archipelago', 'blkdebug', 'blkverify', 'bochs', 'cloop',
> @@ -2134,7 +2134,7 @@
>  #
>  # @path:        absolute path to image file in gluster volume
>  #
> -# @server:      gluster server description
> +# @server:      gluster servers description
>  #
>  # @debug-level: #optional libgfapi log level (default '4' which is Error)
>  #
> @@ -2144,7 +2144,7 @@
>    'data': { 'volume': 'str',
>              'path': 'str',
>              'server': ['GlusterServer'],
> -            '*debug_level': 'int' } }
> +            '*debug-level': 'int' } }
>  
>  ##
>  # @BlockdevOptions
> -- 
> 2.7.4
> 

Thanks,

Applied to my block branch:

git://github.com/codyprime/qemu-kvm-jtc.git block

-Jeff