From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51912) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bRcKA-0000xu-99 for qemu-devel@nongnu.org; Mon, 25 Jul 2016 05:37:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bRcK6-0002JF-1e for qemu-devel@nongnu.org; Mon, 25 Jul 2016 05:37:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54058) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bRcK5-0002JA-Ry for qemu-devel@nongnu.org; Mon, 25 Jul 2016 05:37:17 -0400 Date: Mon, 25 Jul 2016 17:37:15 +0800 From: Fam Zheng Message-ID: <20160725093715.GC11800@ad.usersys.redhat.com> References: <1469036440-4562-1-git-send-email-mst@redhat.com> <20160721103632.GF32544@pxdev.xzpeter.org> <20160722011337.GA21282@ad.usersys.redhat.com> <20160725024152.GA10856@ad.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PULL v3 00/55] pc, pci, virtio: new features, cleanups, fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers On Mon, 07/25 09:38, Peter Maydell wrote: > On 25 July 2016 at 03:41, Fam Zheng wrote: > > On Fri, 07/22 10:46, Peter Maydell wrote: > >> On 22 July 2016 at 02:13, Fam Zheng wrote: > >> > On Thu, 07/21 11:45, Peter Maydell wrote: > >> >> It failed on several of my test builds, not just one, but these > >> >> things are tricky to avoid if they don't happen on all compilers. > >> >> In this case I think it is a compiler bug: > >> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53119 > >> >> so you'll only see it with an older compiler. > >> > > >> > Could you name the distro and gcc version? If it's worth to keep the buggy > >> > compiler happy, it probably can be added as a docker test. :) > >> > >> I think ubuntu trusty stock gcc and the clang on OSX, probably > >> others too. > > > > We do have ubuntu trusty docker image, but I don't see the failure with this > > pull req. Adding an OSX image to docker is much trickier, so I've not really > > looked into that, yet. Could you give me an exact gcc version number that > > triggers the thing, to test again? > > gcc (Ubuntu/Linaro 4.8.2-19ubuntu1) 4.8.2 on ubuntu trusty armhf > gcc (Ubuntu/Linaro 4.8.4-2ubuntu1~14.04.1) 4.8.4 on ubuntu trusty aarch64 > gcc (Ubuntu 4.8.4-2ubuntu1~14.04.3) 4.8.4 on ubuntu trusty x86-64 > gcc (GCC) 4.8.3 20140911 (Red Hat 4.8.3-7) on Fedora 20 ppc64be > > I think I may have been wrong about OSX clang complaining > (at least, those are the only errors in the log files I still have). Cool, so we do have that version, it's the -Werror=missing-braces option we are missing. Are there any other recommended gcc options I can add to tests/docker/ (the criteria is simply "if this stops you from processing a pull, it should be tested" :)? Fam