From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60550) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bRd2M-0005y3-4e for qemu-devel@nongnu.org; Mon, 25 Jul 2016 06:23:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bRd2J-0003Dv-RI for qemu-devel@nongnu.org; Mon, 25 Jul 2016 06:23:01 -0400 Date: Mon, 25 Jul 2016 20:22:55 +1000 From: David Gibson Message-ID: <20160725102255.GE17429@voom.fritz.box> References: <1469440764-61619-1-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vmttodhTwj0NAgWp" Content-Disposition: inline In-Reply-To: <1469440764-61619-1-git-send-email-imammedo@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 0/6] Fix migration issues with arbitrary cpu-hot(un)plug List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, Paolo Bonzini , Peter Crosthwaite , Richard Henderson , Eduardo Habkost , "Michael S. Tsirkin" , Alexander Graf , Riku Voipio , Bharata B Rao , qemu-ppc@nongnu.org --vmttodhTwj0NAgWp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 25, 2016 at 11:59:18AM +0200, Igor Mammedov wrote: > Changes from v1: > - be conservative, drop QTAIL_*() macros hunks and do list element > check/cleanup localy in cpu_exec_exit() > - fix conflict caused by above > - update Reviewed-bys fom v1 > - drop spapr patches as they will be a bit different and depend > on not yet applied to master patch: > 'spapr: disintricate core-id from DT semantics' >=20 > Series fixes migration issues caused by unstable cpu_index which depended > on order cpus were created/destroyed. It follows David's idea to make > cpu_index assignable by selected boards if board supports cpu-hotplug > with device_add and needs stable cpu_index/'migration id' but leaves > behaviour of the same as before for users that don't care about > cpu-hot(un)plug making changes low-risk. Looks good. I'd like to see this merged ASAP, and then I can sort out the ppc / spapr changes we need based on it. > tested with: > SRC -snapshot -enable-kvm -smp 1,maxcpus=3D3 -m 256M guest.img -monitor= stdio \ > -device qemu64-x86_64-cpu,id=3Dcpudel,apic-id=3D1 \ > -device qemu64-x86_64-cpu,apic-id=3D2=20 > (qemu) device_del cpudel > (qemu) stop > (qemu) migrate "exec:gzip -c > STATEFILE.gz" > =20 > DST -snapshot -enable-kvm -smp 1,maxcpus=3D3 -m 256M guest.img -monitor= stdio \ > -device qemu64-x86_64-cpu,apic-id=3D2 \ > -incoming "exec: gzip -c -d STATEFILE.gz" >=20 > git tree to test with: > https://github.com/imammedo/qemu cpu-index-stable-v2 > to view > https://github.com/imammedo/qemu/commits/cpu-index-stable-v2 >=20 > CC: Paolo Bonzini > CC: Peter Crosthwaite > CC: Richard Henderson > CC: Eduardo Habkost > CC: "Michael S. Tsirkin" > CC: David Gibson > CC: Alexander Graf > CC: Riku Voipio > CC: Bharata B Rao > CC: qemu-ppc@nongnu.org >=20 >=20 > Igor Mammedov (6): > exec: reduce CONFIG_USER_ONLY ifdeffenery > exec: don't use cpu_index to detect if cpu_exec_init()'s been called > for cpu > exec: set cpu_index only if it's not been explictly set > qdev: fix object reference leak in case device.realize() fails > pc: init CPUState->cpu_index with index in possible_cpus[] > Revert "pc: Enforce adding CPUs contiguously and removing them in > opposite order" >=20 > bsd-user/qemu.h | 2 -- > include/exec/exec-all.h | 12 +++++++++ > include/qom/cpu.h | 2 ++ > linux-user/qemu.h | 2 -- > exec.c | 66 +++++++++----------------------------------= ------ > hw/core/qdev.c | 8 +++++- > hw/i386/pc.c | 38 +++------------------------- > qom/cpu.c | 2 +- > 8 files changed, 38 insertions(+), 94 deletions(-) >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --vmttodhTwj0NAgWp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXleh/AAoJEGw4ysog2bOSmDQP/icK8zf89wPHwj5inmCYGrCk Hzw+JOFBBPTBM5fWMHfmTFAT5Tl0f7UlBgdn4uFideg0YA2SPD8mfEjEXd1J9iye SvNIuJhI7lr5CALkDcn9EWCaypt0maLSIV20bFEc0cdm+HY5rSHtYem8dv3blidO aOXibOZT2blO+BOxbrm4Ow4kePqxs4jNJHNMR7yWjPXmhAIqeGhmx/ulfer8jTvW wystQ/Dd+sXv2t3DfXj+nDoyphtVZwz9VzcTuRTlfncpBkNAAPPVe5eLpgeihKj1 +xrOuoMEub7KbpQuAWiHp34P+TSELiItI+9XucKLv0RiphOFVQfWAB5HVOZufzgr AW0HBMO/qVgOOc+0rVkpaLLuiTTqMQaXCwZLOxor0CZPN+px7zsjXP59am3XN0gg 1NCh60lakYSIqFRQLp3S5kPfpA9jqpzNQWdps/A7yAcGJ8iG7SoYIRmUJibdEuFm gh6Ukpib1L9akRcp4unCcv006k/+YMAX3Ovlbu829S8Dho45cBqC/to0+zd91Bft MA+4oCJbAMOVkgszKy4odU9Rjjq1PIjJ0r6Qu317Q3nu6x7N5kpRp+1J97CGuRIc XJjpOpQPXO09REkIas2OuRcPC56DKIhjtOxo7+qyS16o6W98Jw/1XbSWI7GTEESz YnI4Rn76aYXMPgA094Gu =JKOt -----END PGP SIGNATURE----- --vmttodhTwj0NAgWp--