From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38304) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bRfpb-00014l-KD for qemu-devel@nongnu.org; Mon, 25 Jul 2016 09:22:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bRfpW-0005VO-LL for qemu-devel@nongnu.org; Mon, 25 Jul 2016 09:22:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56715) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bRfpW-0005VI-FW for qemu-devel@nongnu.org; Mon, 25 Jul 2016 09:21:58 -0400 Date: Mon, 25 Jul 2016 21:21:56 +0800 From: Fam Zheng Message-ID: <20160725132156.GA28499@ad.usersys.redhat.com> References: <1469036440-4562-1-git-send-email-mst@redhat.com> <20160721103632.GF32544@pxdev.xzpeter.org> <20160722011337.GA21282@ad.usersys.redhat.com> <20160725024152.GA10856@ad.usersys.redhat.com> <20160725093715.GC11800@ad.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PULL v3 00/55] pc, pci, virtio: new features, cleanups, fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers On Mon, 07/25 10:48, Peter Maydell wrote: > On 25 July 2016 at 10:37, Fam Zheng wrote: > > Cool, so we do have that version, it's the -Werror=missing-braces option we are > > missing. Are there any other recommended gcc options I can add to > > tests/docker/ (the criteria is simply "if this stops you from processing a > > pull, it should be tested" :)? > > My pull tests just use the default configure options here. In > particular -Wmissing-braces is part of -Wall, and -Werror is > enabled by default for Linux builds from git. Okay, there isn't a .git in the docker checkout, so -Werror is turned off by configure. Looks like I should add --enable-werror to the configure command. Fam