From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47182) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bRgXX-0005FE-B8 for qemu-devel@nongnu.org; Mon, 25 Jul 2016 10:07:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bRgXW-0006MG-58 for qemu-devel@nongnu.org; Mon, 25 Jul 2016 10:07:27 -0400 Received: from hall.aurel32.net ([2001:bc8:30d7:100::1]:34131) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bRgXV-0006M6-VZ for qemu-devel@nongnu.org; Mon, 25 Jul 2016 10:07:26 -0400 Date: Mon, 25 Jul 2016 16:07:23 +0200 From: Aurelien Jarno Message-ID: <20160725140723.GA16123@aurel32.net> References: <1466740107-15042-1-git-send-email-rth@twiddle.net> <1466740107-15042-7-git-send-email-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1466740107-15042-7-git-send-email-rth@twiddle.net> Subject: Re: [Qemu-devel] [PATCH v3 6/9] tcg: Fold life data into TCGOp List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org, mark.cave-ayland@ilande.co.uk, atar4qemu@gmail.com On 2016-06-23 20:48, Richard Henderson wrote: > Reduce the size of other bitfields to make room. > This reduces the cache footprint of compilation. > > Signed-off-by: Richard Henderson > --- > tcg/tcg.c | 9 +++------ > tcg/tcg.h | 26 ++++++++++++++------------ > 2 files changed, 17 insertions(+), 18 deletions(-) This looks fine and goes in the right direction of having all the data at the same location. In the long term it might be useful to have the TCG stream and the associated data together to implement more agressive optimisations. Reviewed-by: Aurelien Jarno -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurelien@aurel32.net http://www.aurel32.net