qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
	Peter Crosthwaite <crosthwaite.peter@gmail.com>,
	Richard Henderson <rth@twiddle.net>,
	Eduardo Habkost <ehabkost@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Alexander Graf <agraf@suse.de>, Riku Voipio <riku.voipio@iki.fi>,
	Bharata B Rao <bharata@linux.vnet.ibm.com>,
	qemu-ppc@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 0/6] Fix migration issues with arbitrary cpu-hot(un)plug
Date: Tue, 26 Jul 2016 13:16:59 +1000	[thread overview]
Message-ID: <20160726031659.GH17429@voom.fritz.box> (raw)
In-Reply-To: <1469440764-61619-1-git-send-email-imammedo@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 2052 bytes --]

On Mon, Jul 25, 2016 at 11:59:18AM +0200, Igor Mammedov wrote:
> Changes from v1:
>   - be conservative, drop QTAIL_*() macros hunks and do list element
>     check/cleanup localy in cpu_exec_exit()
>   - fix conflict caused by above
>   - update Reviewed-bys fom v1
>   - drop spapr patches as they will be a bit different and depend
>     on not yet applied to master patch:
>      'spapr: disintricate core-id from DT semantics'
> 
> Series fixes migration issues caused by unstable cpu_index which depended
> on order cpus were created/destroyed. It follows David's idea to make
> cpu_index assignable by selected boards if board supports cpu-hotplug
> with device_add and needs stable cpu_index/'migration id' but leaves
> behaviour of the same as before for users that don't care about
> cpu-hot(un)plug making changes low-risk.
> 
> tested with:
>   SRC -snapshot -enable-kvm -smp 1,maxcpus=3 -m 256M guest.img -monitor stdio \
>        -device qemu64-x86_64-cpu,id=cpudel,apic-id=1 \
>        -device qemu64-x86_64-cpu,apic-id=2 
>   (qemu) device_del cpudel
>   (qemu) stop
>   (qemu) migrate "exec:gzip -c > STATEFILE.gz"
>   
>   DST -snapshot -enable-kvm -smp 1,maxcpus=3 -m 256M guest.img -monitor stdio \
>       -device qemu64-x86_64-cpu,apic-id=2 \
>       -incoming "exec: gzip -c -d STATEFILE.gz"
> 
> git tree to test with:
>      https://github.com/imammedo/qemu cpu-index-stable-v2
>  to view
>      https://github.com/imammedo/qemu/commits/cpu-index-stable-v2

Eduardo,

Igor said he thought these would probably go in via your tree.  Do you
have any kind of ETA for this?

I've put these into my ppc-for-2.7 tree, not because I intend to push
them from there, but so I can do the ppc specific fixups on top of
them.  I'm hoping these will disappear in a rebase before my next pull
request.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  parent reply	other threads:[~2016-07-26  4:12 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-25  9:59 [Qemu-devel] [PATCH v2 0/6] Fix migration issues with arbitrary cpu-hot(un)plug Igor Mammedov
2016-07-25  9:59 ` [Qemu-devel] [PATCH v2 1/6] exec: reduce CONFIG_USER_ONLY ifdeffenery Igor Mammedov
2016-07-25  9:59 ` [Qemu-devel] [PATCH v2 2/6] exec: don't use cpu_index to detect if cpu_exec_init()'s been called for cpu Igor Mammedov
2016-07-25 10:18   ` David Gibson
2016-07-25  9:59 ` [Qemu-devel] [PATCH v2 3/6] exec: set cpu_index only if it's not been explictly set Igor Mammedov
2016-07-26 18:28   ` Eduardo Habkost
2016-07-27  8:45     ` Igor Mammedov
2016-07-25  9:59 ` [Qemu-devel] [PATCH v2 4/6] qdev: fix object reference leak in case device.realize() fails Igor Mammedov
2016-07-25  9:59 ` [Qemu-devel] [PATCH v2 5/6] pc: init CPUState->cpu_index with index in possible_cpus[] Igor Mammedov
2016-07-25  9:59 ` [Qemu-devel] [PATCH v2 6/6] Revert "pc: Enforce adding CPUs contiguously and removing them in opposite order" Igor Mammedov
2016-07-25 10:22 ` [Qemu-devel] [PATCH v2 0/6] Fix migration issues with arbitrary cpu-hot(un)plug David Gibson
2016-07-26  3:16 ` David Gibson [this message]
2016-07-26 15:26   ` Eduardo Habkost
2016-07-26 15:22 ` Michael S. Tsirkin
2016-07-26 18:35 ` Eduardo Habkost
2016-07-27  9:24 ` [Qemu-devel] [PATCH v2 7/6] exec: ensure the only one cpu_index allocation method is used Igor Mammedov
2016-07-28  5:49   ` David Gibson
2016-08-02 11:40   ` Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160726031659.GH17429@voom.fritz.box \
    --to=david@gibson.dropbear.id.au \
    --cc=agraf@suse.de \
    --cc=bharata@linux.vnet.ibm.com \
    --cc=crosthwaite.peter@gmail.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=riku.voipio@iki.fi \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).