From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53533) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bRtjf-0007qY-S7 for qemu-devel@nongnu.org; Tue, 26 Jul 2016 00:12:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bRtjd-0005Jd-Ox for qemu-devel@nongnu.org; Tue, 26 Jul 2016 00:12:50 -0400 Date: Tue, 26 Jul 2016 13:27:52 +1000 From: David Gibson Message-ID: <20160726032752.GI17429@voom.fritz.box> References: <1469116479-233280-1-git-send-email-imammedo@redhat.com> <1469116479-233280-7-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="fckbADODYWZD5TdN" Content-Disposition: inline In-Reply-To: <1469116479-233280-7-git-send-email-imammedo@redhat.com> Subject: Re: [Qemu-devel] [PATCH 6/8] spapr: init CPUState->cpu_index with index relative to core-id List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, Riku Voipio , Eduardo Habkost , "Michael S. Tsirkin" , Peter Crosthwaite , Alexander Graf , qemu-ppc@nongnu.org, Bharata B Rao , Paolo Bonzini , Richard Henderson --fckbADODYWZD5TdN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 21, 2016 at 05:54:37PM +0200, Igor Mammedov wrote: > It will enshure that cpu_index for a given cpu stays the same > regardless of the order cpus has been created/deleted and so > it would be possible to migrate QEMU instance with out of order > created CPU. >=20 > Signed-off-by: Igor Mammedov Now that I've merged Greg's patch fix the core ids so this is no longer a problem, I've merged this patch into ppc-for-2.7 on top of your more-recent version of this series. > --- > hw/ppc/spapr_cpu_core.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/hw/ppc/spapr_cpu_core.c b/hw/ppc/spapr_cpu_core.c > index 4bfc96b..f68e88d 100644 > --- a/hw/ppc/spapr_cpu_core.c > +++ b/hw/ppc/spapr_cpu_core.c > @@ -309,9 +309,13 @@ static void spapr_cpu_core_realize(DeviceState *dev,= Error **errp) > sc->threads =3D g_malloc0(size * cc->nr_threads); > for (i =3D 0; i < cc->nr_threads; i++) { > char id[32]; > + CPUState *cs; > + > obj =3D sc->threads + i * size; > =20 > object_initialize(obj, size, typename); > + cs =3D CPU(obj); > + cs->cpu_index =3D cc->core_id + i; > snprintf(id, sizeof(id), "thread[%d]", i); > object_property_add_child(OBJECT(sc), id, obj, &local_err); > if (local_err) { --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --fckbADODYWZD5TdN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXlti4AAoJEGw4ysog2bOSks8P/3yt3fSzq4cOB1HKfD1NmHEz c6gmvQGy0XoVDY+HEZO7DrzARBPXYLg9ppjT7DjtBTla1OPIKkQJXwQHqogefJuH YKGp2MgoL1/mwvk7oflVvftv3/c1TuVqnmdBAWJaGbJduIdtsut00Bdpt1vn+zPr iNoYKF1T6T3f0Ry4JGtWTKlS4zPZrv5AffAqmxqowUoF0Blw8pDwTA9Bhx9PHRod qIbuz1pqPVMHpNfDntfeMoDjJWCB9y1DCMQ3qg3Mj6f1PR1NVE9Y95IIBW4PY7gY dLP2lFRpTxyBP0QyCFG5QZhBCD1mF+L36gHUiEU+Ul1s/Zyi4mIY3qCXbvai3Rlj uvmiqT3g/tWUqiQYbUlSc6MnciFnc6R7tp8pg3SLspF23ioa3eJfRS2su9PNUIvR Hn8uhX+VRL8XwWkzJf9MBdBPRgv/KNdUDk6DMCPmm3LBdHmOptPX9FJUd8DvHyBQ a6aFRIpxQ7RG45/nw0I5Nyk+znj3/XCY6XLUqbP9vLzlOm/B+H75hxJHLoJWFShj IUDKbpZ6A1EIKFYi0v+ecxuUbKRIFqvyIO4kTSpqhWjbTLKwAHLErkY/LYCqlK0P REpYLN/dguLZi/ZjQAZjz8kpsdSQlHgVFQQepEb391Czu73oKBhc5KxR3LB/NVwZ aCVAqQQFRSRwEo75tCHN =907g -----END PGP SIGNATURE----- --fckbADODYWZD5TdN--