From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33693)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1bRuVT-0008UE-Ku
	for qemu-devel@nongnu.org; Tue, 26 Jul 2016 01:02:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1bRuVO-0006V8-5Y
	for qemu-devel@nongnu.org; Tue, 26 Jul 2016 01:02:14 -0400
Received: from mx1.redhat.com ([209.132.183.28]:46024)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <amit.shah@redhat.com>) id 1bRuVN-0006Uy-Vz
	for qemu-devel@nongnu.org; Tue, 26 Jul 2016 01:02:10 -0400
Date: Tue, 26 Jul 2016 10:31:59 +0530
From: Amit Shah <amit.shah@redhat.com>
Message-ID: <20160726050159.GA27202@grmbl.mre>
References: <1467733400-17206-1-git-send-email-mst@redhat.com>
	<20160705184740-mutt-send-email-mst@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160705184740-mutt-send-email-mst@redhat.com>
Subject: Re: [Qemu-devel] [PULL v2 27/30] mptsas: remove unnecessary
 internal msi state flag
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, Marcel Apfelbaum <marcel@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Cao jin <caoj.fnst@cn.fujitsu.com>, Markus Armbruster <armbru@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

On (Tue) 05 Jul 2016 [18:47:40], Michael S. Tsirkin wrote:
> From: Cao jin <caoj.fnst@cn.fujitsu.com>
> 
> internal flag msi_in_use in unnecessary, msi_uninit() could be called
> directly, and msi_enabled() is enough to check device msi state.
> 
> cc: Markus Armbruster <armbru@redhat.com>
> cc: Marcel Apfelbaum <marcel@redhat.com>
> cc: Paolo Bonzini <pbonzini@redhat.com>
> cc: Michael S. Tsirkin <mst@redhat.com>
> 
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

[...]

>  static void mptsas_reset(DeviceState *dev)
> @@ -1375,7 +1370,6 @@ static const VMStateDescription vmstate_mptsas = {
>      .post_load = mptsas_post_load,
>      .fields      = (VMStateField[]) {
>          VMSTATE_PCI_DEVICE(dev, MPTSASState),
> -        VMSTATE_BOOL(msi_in_use, MPTSASState),

This removes vmstate -- please use 'unused' instead of removing this
value.

Flagged by the static checker.


		Amit