From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43473)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1bRxfB-0007TS-Ik
	for qemu-devel@nongnu.org; Tue, 26 Jul 2016 04:24:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1bRxf7-0003x5-AY
	for qemu-devel@nongnu.org; Tue, 26 Jul 2016 04:24:28 -0400
Received: from mx1.redhat.com ([209.132.183.28]:51165)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <berrange@redhat.com>) id 1bRxf7-0003x1-52
	for qemu-devel@nongnu.org; Tue, 26 Jul 2016 04:24:25 -0400
Date: Tue, 26 Jul 2016 09:24:20 +0100
From: "Daniel P. Berrange" <berrange@redhat.com>
Message-ID: <20160726082420.GB4801@redhat.com>
Reply-To: "Daniel P. Berrange" <berrange@redhat.com>
References: <cover.1469174334.git.amit.shah@redhat.com>
	<66613974468fb6e1609fb3eabf55981b1ee436cf.1469174334.git.amit.shah@redhat.com>
	<13e4aa00-1783-4c82-ac77-5e5b1bf86f3a@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <13e4aa00-1783-4c82-ac77-5e5b1bf86f3a@redhat.com>
Subject: Re: [Qemu-devel] [PULL 4/7] scripts: refactor the VM class in
 iotests for reuse
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Max Reitz <mreitz@redhat.com>
Cc: Amit Shah <amit.shah@redhat.com>, qemu list <qemu-devel@nongnu.org>, Peter Maydell <peter.maydell@linaro.org>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Juan Quintela <quintela@redhat.com>

On Tue, Jul 26, 2016 at 02:23:52AM +0200, Max Reitz wrote:
> On 22.07.2016 10:00, Amit Shah wrote:
> > From: "Daniel P. Berrange" <berrange@redhat.com>
> > 
> > The iotests module has a python class for controlling QEMU
> > processes. Pull the generic functionality out of this file
> > and create a scripts/qemu.py module containing a QEMUMachine
> > class. Put the QTest integration support into a subclass
> > QEMUQtestMachine.
> > 
> > Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> > Message-Id: <1469020993-29426-4-git-send-email-berrange@redhat.com>
> > Signed-off-by: Amit Shah <amit.shah@redhat.com>
> > ---
> >  scripts/qemu.py               | 202 ++++++++++++++++++++++++++++++++++++++++++
> >  scripts/qtest.py              |  34 +++++++
> >  tests/qemu-iotests/iotests.py | 135 +---------------------------
> >  3 files changed, 240 insertions(+), 131 deletions(-)
> >  create mode 100644 scripts/qemu.py
> 
> Hm, I have even more questions...
> 
> (I'm starting to wonder if I'm doing anything horribly wrong, because
> this patch basically completely breaks the Python iotests for me.)

[snip]

I'll investigate this and send any neccessary fixes asap.


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|