From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44870) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bS0NS-0006OQ-Ts for qemu-devel@nongnu.org; Tue, 26 Jul 2016 07:18:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bS0NM-0006UL-UN for qemu-devel@nongnu.org; Tue, 26 Jul 2016 07:18:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46459) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bS0NM-0006UH-P1 for qemu-devel@nongnu.org; Tue, 26 Jul 2016 07:18:16 -0400 Date: Tue, 26 Jul 2016 16:48:06 +0530 From: Amit Shah Message-ID: <20160726111806.GA26166@grmbl.mre> References: <1467733400-17206-1-git-send-email-mst@redhat.com> <20160705184740-mutt-send-email-mst@redhat.com> <20160726050159.GA27202@grmbl.mre> <57971160.5090509@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57971160.5090509@cn.fujitsu.com> Subject: Re: [Qemu-devel] [PULL v2 27/30] mptsas: remove unnecessary internal msi state flag List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cao jin Cc: "Michael S. Tsirkin" , qemu-devel@nongnu.org, Marcel Apfelbaum , Peter Maydell , Markus Armbruster , Paolo Bonzini On (Tue) 26 Jul 2016 [15:29:36], Cao jin wrote: > Hi Amit > > I will take care of this. > BTW, did't see it in coverity scan outstanding defects, Do I missed or it is > checked by other static check tools? This is checked with the vmstate static checker -- scripts/vmstate-static-checker.py. The -dump-vmstate cmdline option to qemu gives a json file that the static checker uses as input. Get a 'before' and 'after' version of the json files, and pass those on to the checker with '-s' and '-d' arguments respectively. Thanks, Amit