From: Amit Shah <amit.shah@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PULL 26/28] apic: Use apic_id as apic's migration instance_id
Date: Tue, 26 Jul 2016 18:41:22 +0530 [thread overview]
Message-ID: <20160726130906.GA24341@grmbl.mre> (raw)
In-Reply-To: <20160726145839.3cdd8213@nial.brq.redhat.com>
On (Tue) 26 Jul 2016 [14:58:39], Igor Mammedov wrote:
> > This was flagged by a nightly run of the static checker when this
> > series was pulled. On a 'before' tree, ie one w/o the patches, do
> > this:
> >
> > qemu -dump-vmstate before.json
> >
> > and for after:
> >
> > qemu -dump-vmstate after.json
> >
> > then,
> >
> > python ./scripts/vmstate-static-checker.py -s before.json -d after.json
> I don't think it is valid comparison though, as it compares default PC machines.
> In this case it's pc-i440fx-2.6 and pc-i440fx-2.7, you see the difference
> which is expected due to instance_id change.
>
> You shouldn't see it when comparing same machine types.
No, this is comparing the git tree just before and after the series is
applied.
Amit
next prev parent reply other threads:[~2016-07-26 13:11 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-20 15:08 [Qemu-devel] [PULL v2 00/28] x86 queue, 2016-07-20 Eduardo Habkost
2016-07-20 15:08 ` [Qemu-devel] [PULL 01/28] target-i386: Provide TCG_PHYS_ADDR_BITS Eduardo Habkost
2016-07-20 15:08 ` [Qemu-devel] [PULL 02/28] target-i386: Allow physical address bits to be set Eduardo Habkost
2016-07-20 15:08 ` [Qemu-devel] [PULL 03/28] target-i386: Mask mtrr mask based on CPU physical address limits Eduardo Habkost
2016-07-20 15:08 ` [Qemu-devel] [PULL 04/28] target-i386: Fill high bits of mtrr mask Eduardo Habkost
2016-07-20 15:08 ` [Qemu-devel] [PULL 05/28] target-i386: Use uint32_t for X86CPU.apic_id Eduardo Habkost
2016-07-20 15:08 ` [Qemu-devel] [PULL 06/28] pc: Add x86_topo_ids_from_apicid() Eduardo Habkost
2016-07-20 15:08 ` [Qemu-devel] [PULL 07/28] target-i386: Set physical address bits based on host Eduardo Habkost
2016-07-20 15:08 ` [Qemu-devel] [PULL 08/28] pc: Extract CPU lookup into a separate function Eduardo Habkost
2016-07-20 15:08 ` [Qemu-devel] [PULL 09/28] pc: cpu: Consolidate apic-id validity checks in pc_cpu_pre_plug() Eduardo Habkost
2016-07-20 15:08 ` [Qemu-devel] [PULL 10/28] target-i386: Replace custom apic-id setter/getter with static property Eduardo Habkost
2016-07-20 15:08 ` [Qemu-devel] [PULL 11/28] target-i386: Add socket/core/thread properties to X86CPU Eduardo Habkost
2016-07-20 15:08 ` [Qemu-devel] [PULL 12/28] target-i386: Add support for UMIP and RDPID CPUID bits Eduardo Habkost
2016-07-20 15:08 ` [Qemu-devel] [PULL 13/28] target-i386: cpu: Do not ignore error and fix apic parent Eduardo Habkost
2016-07-20 15:08 ` [Qemu-devel] [PULL 14/28] target-i386: Fix apic object leak when CPU is deleted Eduardo Habkost
2016-07-20 15:08 ` [Qemu-devel] [PULL 15/28] pc: Set APIC ID based on socket/core/thread ids if it's not been set yet Eduardo Habkost
2016-07-20 15:08 ` [Qemu-devel] [PULL 16/28] pc: Delay setting number of boot CPUs to machine_done time Eduardo Habkost
2016-07-20 15:08 ` [Qemu-devel] [PULL 17/28] pc: Register created initial and hotpluged CPUs in one place pc_cpu_plug() Eduardo Habkost
2016-07-20 15:08 ` [Qemu-devel] [PULL 18/28] pc: Forbid BSP removal Eduardo Habkost
2016-07-20 15:08 ` [Qemu-devel] [PULL 19/28] pc: Enforce adding CPUs contiguously and removing them in opposite order Eduardo Habkost
2016-07-20 15:08 ` [Qemu-devel] [PULL 20/28] pc: cpu: Allow device_add to be used with x86 cpu Eduardo Habkost
2016-07-20 15:08 ` [Qemu-devel] [PULL 21/28] pc: Implement query-hotpluggable-cpus callback Eduardo Habkost
2016-07-20 15:08 ` [Qemu-devel] [PULL 22/28] apic: move MAX_APICS check to 'apic' class Eduardo Habkost
2016-07-20 15:08 ` [Qemu-devel] [PULL 23/28] apic: Drop APICCommonState.idx and use APIC ID as index in local_apics[] Eduardo Habkost
2016-07-20 15:08 ` [Qemu-devel] [PULL 24/28] apic: kvm-apic: Fix crash due to access to freed memory region Eduardo Habkost
2016-07-20 15:08 ` [Qemu-devel] [PULL 25/28] (kvm)apic: Add unrealize callbacks Eduardo Habkost
2016-07-20 15:08 ` [Qemu-devel] [PULL 26/28] apic: Use apic_id as apic's migration instance_id Eduardo Habkost
2016-07-26 5:11 ` Amit Shah
2016-07-26 8:00 ` Igor Mammedov
2016-07-26 11:47 ` Amit Shah
2016-07-26 12:58 ` Igor Mammedov
2016-07-26 13:11 ` Amit Shah [this message]
2016-07-26 13:41 ` Igor Mammedov
2016-07-26 14:16 ` Igor Mammedov
2016-07-26 19:19 ` Eduardo Habkost
2016-07-27 7:41 ` Igor Mammedov
2016-07-26 9:41 ` Igor Mammedov
2016-07-26 12:26 ` Amit Shah
2016-07-20 15:08 ` [Qemu-devel] [PULL 27/28] target-i386: Add x86_cpu_unrealizefn() Eduardo Habkost
2016-07-20 15:08 ` [Qemu-devel] [PULL 28/28] pc: Make device_del CPU work for x86 CPUs Eduardo Habkost
2016-07-20 20:59 ` [Qemu-devel] [PULL v2 00/28] x86 queue, 2016-07-20 Peter Maydell
-- strict thread matches above, loose matches on Subject: below --
2016-07-19 17:22 [Qemu-devel] [PULL 00/28] x86 queue for -rc0 Eduardo Habkost
2016-07-19 17:22 ` [Qemu-devel] [PULL 26/28] apic: Use apic_id as apic's migration instance_id Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160726130906.GA24341@grmbl.mre \
--to=amit.shah@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).