From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43953)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1bS28Z-0006gx-6r
	for qemu-devel@nongnu.org; Tue, 26 Jul 2016 09:11:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1bS28T-00070W-0X
	for qemu-devel@nongnu.org; Tue, 26 Jul 2016 09:11:06 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48135)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1bS28S-00070S-Qy
	for qemu-devel@nongnu.org; Tue, 26 Jul 2016 09:11:00 -0400
Date: Tue, 26 Jul 2016 16:10:56 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20160726160901-mutt-send-email-mst@kernel.org>
References: <1467733400-17206-1-git-send-email-mst@redhat.com>
	<20160705184740-mutt-send-email-mst@redhat.com>
	<20160726050159.GA27202@grmbl.mre>
	<57971160.5090509@cn.fujitsu.com>
	<20160726111806.GA26166@grmbl.mre>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160726111806.GA26166@grmbl.mre>
Subject: Re: [Qemu-devel] [PULL v2 27/30] mptsas: remove unnecessary
 internal msi state flag
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: Cao jin <caoj.fnst@cn.fujitsu.com>, qemu-devel@nongnu.org, Marcel Apfelbaum <marcel@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Markus Armbruster <armbru@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

On Tue, Jul 26, 2016 at 04:48:06PM +0530, Amit Shah wrote:
> On (Tue) 26 Jul 2016 [15:29:36], Cao jin wrote:
> > Hi Amit
> > 
> > I will take care of this.
> > BTW, did't see it in coverity scan outstanding defects, Do I missed or it is
> > checked by other static check tools?
> 
> This is checked with the vmstate static checker --
> scripts/vmstate-static-checker.py.
> 
> The -dump-vmstate cmdline option to qemu gives a json file that the
> static checker uses as input.  Get a 'before' and 'after' version of
> the json files, and pass those on to the checker with '-s' and '-d'
> arguments respectively.
> 
> Thanks,
> 
> 		Amit

How about adding this to make check?
You can run this with a given machine type to avoid too much churn.

-- 
MST