From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:59713)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1bS39a-0001iP-L2
	for qemu-devel@nongnu.org; Tue, 26 Jul 2016 10:16:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1bS39V-0004uC-An
	for qemu-devel@nongnu.org; Tue, 26 Jul 2016 10:16:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:51507)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1bS39V-0004u4-4f
	for qemu-devel@nongnu.org; Tue, 26 Jul 2016 10:16:09 -0400
Date: Tue, 26 Jul 2016 16:16:04 +0200
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20160726161604.371397e2@nial.brq.redhat.com>
In-Reply-To: <20160726130906.GA24341@grmbl.mre>
References: <1469027314-31655-1-git-send-email-ehabkost@redhat.com>
	<1469027314-31655-27-git-send-email-ehabkost@redhat.com>
	<20160726051138.GB27202@grmbl.mre>
	<20160726100049.7f003705@nial.brq.redhat.com>
	<20160726114655.GB26166@grmbl.mre>
	<20160726145839.3cdd8213@nial.brq.redhat.com>
	<20160726130906.GA24341@grmbl.mre>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 26/28] apic: Use apic_id as apic's migration
 instance_id
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>, Richard Henderson <rth@twiddle.net>, Eduardo Habkost <ehabkost@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

On Tue, 26 Jul 2016 18:41:22 +0530
Amit Shah <amit.shah@redhat.com> wrote:

> On (Tue) 26 Jul 2016 [14:58:39], Igor Mammedov wrote:
> > > This was flagged by a nightly run of the static checker when this
> > > series was pulled.  On a 'before' tree, ie one w/o the patches, do
> > > this:
> > > 
> > > qemu -dump-vmstate before.json
> > > 
> > > and for after:
> > > 
> > > qemu -dump-vmstate after.json
> > > 
> > > then,
> > > 
> > > python ./scripts/vmstate-static-checker.py -s before.json -d after.json  
> > I don't think it is valid comparison though, as it compares default PC machines.
> > In this case it's pc-i440fx-2.6 and pc-i440fx-2.7, you see the difference
> > which is expected due to instance_id change.
> > 
> > You shouldn't see it when comparing same machine types.  
> 
> No, this is comparing the git tree just before and after the series is
> applied.
I've checked dump_vmstate_json_to_file() implementation and it looks like
it dumps only dc->vmsd enabled devices.

In this patch vmstate registration has been moved to to apic_comon_realize()
that's why dump_vmstate_json_to_file() doesn't dump apics anymore and you see the change

> 
> 		Amit
>