From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57082) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSI0L-0004EU-SE for qemu-devel@nongnu.org; Wed, 27 Jul 2016 02:07:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bSI0J-0001eD-5I for qemu-devel@nongnu.org; Wed, 27 Jul 2016 02:07:40 -0400 Date: Wed, 27 Jul 2016 15:42:57 +1000 From: David Gibson Message-ID: <20160727054257.GG17429@voom.fritz.box> References: <1469561218-3067-1-git-send-email-nikunj@linux.vnet.ibm.com> <1469561218-3067-2-git-send-email-nikunj@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="0NUq3YI6/rBc6tSL" Content-Disposition: inline In-Reply-To: <1469561218-3067-2-git-send-email-nikunj@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH RFC v0 1/6] target-ppc: add dtstsfi[q] instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikunj A Dadhania Cc: qemu-ppc@nongnu.org, rth@twiddle.net, qemu-devel@nongnu.org, bharata@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com, benh@kernel.crashing.org, Sandipan Das --0NUq3YI6/rBc6tSL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 27, 2016 at 12:56:53AM +0530, Nikunj A Dadhania wrote: > From: Sandipan Das >=20 > DFP Test Significance Immediate [Quad] >=20 > Signed-off-by: Sandipan Das > Signed-off-by: Nikunj A Dadhania Reviewed-by: David Gibson > --- > target-ppc/dfp_helper.c | 35 +++++++++++++++++++++++++++++++++++ > target-ppc/helper.h | 2 ++ > target-ppc/translate.c | 22 ++++++++++++++++++++++ > 3 files changed, 59 insertions(+) >=20 > diff --git a/target-ppc/dfp_helper.c b/target-ppc/dfp_helper.c > index db0ede6..9164fe7 100644 > --- a/target-ppc/dfp_helper.c > +++ b/target-ppc/dfp_helper.c > @@ -647,6 +647,41 @@ uint32_t helper_##op(CPUPPCState *env, uint64_t *a, = uint64_t *b) \ > DFP_HELPER_TSTSF(dtstsf, 64) > DFP_HELPER_TSTSF(dtstsfq, 128) > =20 > +#define DFP_HELPER_TSTSFI(op, size) \ > +uint32_t helper_##op(CPUPPCState *env, uint32_t a, uint64_t *b) \ > +{ \ > + struct PPC_DFP dfp; \ > + unsigned uim; \ > + \ > + dfp_prepare_decimal##size(&dfp, 0, b, env); \ > + \ > + uim =3D a & 0x3F; = \ > + \ > + if (unlikely(decNumberIsSpecial(&dfp.b))) { \ > + dfp.crbf =3D 1; = \ > + } else if (uim =3D=3D 0) { = \ > + dfp.crbf =3D 4; = \ > + } else if (unlikely(decNumberIsZero(&dfp.b))) { \ > + /* Zero has no sig digits */ \ > + dfp.crbf =3D 4; = \ > + } else { \ > + unsigned nsd =3D dfp.b.digits; = \ > + if (uim < nsd) { \ > + dfp.crbf =3D 8; = \ > + } else if (uim > nsd) { \ > + dfp.crbf =3D 4; = \ > + } else { \ > + dfp.crbf =3D 2; = \ > + } \ > + } \ > + \ > + dfp_set_FPCC_from_CRBF(&dfp); \ > + return dfp.crbf; \ > +} > + > +DFP_HELPER_TSTSFI(dtstsfi, 64) > +DFP_HELPER_TSTSFI(dtstsfiq, 128) > + > static void QUA_PPs(struct PPC_DFP *dfp) > { > dfp_set_FPRF_from_FRT(dfp); > diff --git a/target-ppc/helper.h b/target-ppc/helper.h > index 9e4bb7b..68fd19e 100644 > --- a/target-ppc/helper.h > +++ b/target-ppc/helper.h > @@ -645,6 +645,8 @@ DEF_HELPER_3(dtstex, i32, env, fprp, fprp) > DEF_HELPER_3(dtstexq, i32, env, fprp, fprp) > DEF_HELPER_3(dtstsf, i32, env, fprp, fprp) > DEF_HELPER_3(dtstsfq, i32, env, fprp, fprp) > +DEF_HELPER_3(dtstsfi, i32, env, i32, fprp) > +DEF_HELPER_3(dtstsfiq, i32, env, i32, fprp) > DEF_HELPER_5(dquai, void, env, fprp, fprp, i32, i32) > DEF_HELPER_5(dquaiq, void, env, fprp, fprp, i32, i32) > DEF_HELPER_5(dqua, void, env, fprp, fprp, fprp, i32) > diff --git a/target-ppc/translate.c b/target-ppc/translate.c > index d522566..23ef538 100644 > --- a/target-ppc/translate.c > +++ b/target-ppc/translate.c > @@ -8678,6 +8678,24 @@ static void gen_##name(DisasContext *ctx) \ > tcg_temp_free_ptr(rb); \ > } > =20 > +#define GEN_DFP_BF_I_B(name) \ > +static void gen_##name(DisasContext *ctx) \ > +{ \ > + TCGv_i32 uim; \ > + TCGv_ptr rb; \ > + if (unlikely(!ctx->fpu_enabled)) { \ > + gen_exception(ctx, POWERPC_EXCP_FPU); \ > + return; \ > + } \ > + gen_update_nip(ctx, ctx->nip - 4); \ > + uim =3D tcg_const_i32(UIMM5(ctx->opcode)); \ > + rb =3D gen_fprp_ptr(rB(ctx->opcode)); \ > + gen_helper_##name(cpu_crf[crfD(ctx->opcode)], \ > + cpu_env, uim, rb); \ > + tcg_temp_free_i32(uim); \ > + tcg_temp_free_ptr(rb); \ > +} > + > #define GEN_DFP_BF_A_DCM(name) \ > static void gen_##name(DisasContext *ctx) \ > { \ > @@ -8805,6 +8823,8 @@ GEN_DFP_BF_A_B(dtstex) > GEN_DFP_BF_A_B(dtstexq) > GEN_DFP_BF_A_B(dtstsf) > GEN_DFP_BF_A_B(dtstsfq) > +GEN_DFP_BF_I_B(dtstsfi) > +GEN_DFP_BF_I_B(dtstsfiq) > GEN_DFP_T_B_U32_U32_Rc(dquai, SIMM5, RMC) > GEN_DFP_T_B_U32_U32_Rc(dquaiq, SIMM5, RMC) > GEN_DFP_T_A_B_I32_Rc(dqua, RMC) > @@ -11456,6 +11476,8 @@ GEN_DFP_BF_A_B(dtstex, 0x02, 0x05), > GEN_DFP_BF_Ap_Bp(dtstexq, 0x02, 0x05), > GEN_DFP_BF_A_B(dtstsf, 0x02, 0x15), > GEN_DFP_BF_A_Bp(dtstsfq, 0x02, 0x15), > +GEN_DFP_BF_A_B(dtstsfi, 0x03, 0x15), > +GEN_DFP_BF_A_Bp(dtstsfiq, 0x03, 0x15), > GEN_DFP_TE_T_B_RMC_Rc(dquai, 0x03, 0x02), > GEN_DFP_TE_Tp_Bp_RMC_Rc(dquaiq, 0x03, 0x02), > GEN_DFP_T_A_B_RMC_Rc(dqua, 0x03, 0x00), --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --0NUq3YI6/rBc6tSL Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXmEnhAAoJEGw4ysog2bOSM00P/0oZg9Jjvgga6AYLY3u6G581 VcUO2EOVFKYTNh+i2mB//pdWhJqRWGGZ0i8YyOZJH28tJBBwC2+X8gGKn7azRzUl Kjpsxz95yekzrxIGgxBzfi7r2/D7P8H+4hugrHn67U58JXzF1IlqEzzBCLl0L7b3 sboVgKIrlyHh0UySDn9LWoDgJ08ITvAaAM2w7aKJovYayvxekpvIN0gkYPmwE3k3 1eBJ0m6sXZ+ETnB1hjdGUwNL8lOnr0tvS3cCGuThW7Ki8lWY6Og2FPcMyt2WtEsJ w/708ZchWG/bnXmNF9JtbL37yzn6tyF1s+imklzvKEes3Z/LFt+L+Vij+kAgMwI4 1cxpr4TgYy/pwWWTV3fPsrR0JHtnBegAnhmRXx0B70XSjVxkC7YZceNAscxlVynj GZFBOVJaG8XJFTm0+rCPnK90j6Tpgujzq2yOwe/GGxr5riVcF75dtrqp5UYQQyQJ 2ILOsiwTsRfKQeCHOaQX0PrXF1CKlaqiUXpwphRNeX927WXg7phIDclc6rJZl8K8 JLB28kCtytco5nfKF0cPK8bRj5m4Bul4aqmBdqhMjzpCTMdK0Koa2sXIf4H56YV8 XF8gzNH7k3ELuBJ855d1KdtW/0FmGmVxI3n58e99EYakJE84zr43eOmgr0Y/uEhB DHRfhsuHer8dPoyJ+LnF =v0Rk -----END PGP SIGNATURE----- --0NUq3YI6/rBc6tSL--