From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57084) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSI0M-0004Ea-1Y for qemu-devel@nongnu.org; Wed, 27 Jul 2016 02:07:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bSI0J-0001ed-Ix for qemu-devel@nongnu.org; Wed, 27 Jul 2016 02:07:40 -0400 Date: Wed, 27 Jul 2016 15:57:43 +1000 From: David Gibson Message-ID: <20160727055743.GI17429@voom.fritz.box> References: <1469561218-3067-1-git-send-email-nikunj@linux.vnet.ibm.com> <1469561218-3067-4-git-send-email-nikunj@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zuGyJ7KNSMOGsxcs" Content-Disposition: inline In-Reply-To: <1469561218-3067-4-git-send-email-nikunj@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH RFC v0 3/6] target-ppc: add vcmpnez[b, h, w][.] instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikunj A Dadhania Cc: qemu-ppc@nongnu.org, rth@twiddle.net, qemu-devel@nongnu.org, bharata@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com, benh@kernel.crashing.org, Swapnil Bokade --zuGyJ7KNSMOGsxcs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 27, 2016 at 12:56:55AM +0530, Nikunj A Dadhania wrote: > From: Swapnil Bokade >=20 > Adds following instructions: >=20 > vcmpnezb[.]: Vector Compare Not Equal or Zero Byte > vcmpnezh[.]: Vector Compare Not Equal or Zero Halfword > vcmpnezw[.]: Vector Compare Not Equal or Zero Word >=20 > Signed-off-by: Swapnil Bokade > Signed-off-by: Nikunj A Dadhania > --- > target-ppc/helper.h | 6 ++++++ > target-ppc/int_helper.c | 49 +++++++++++++++++++++++++++++++++++++++++++= ++++++ > target-ppc/translate.c | 6 ++++++ > 3 files changed, 61 insertions(+) >=20 > diff --git a/target-ppc/helper.h b/target-ppc/helper.h > index ff6287e..e93b84b 100644 > --- a/target-ppc/helper.h > +++ b/target-ppc/helper.h > @@ -144,6 +144,9 @@ DEF_HELPER_4(vcmpequb, void, env, avr, avr, avr) > DEF_HELPER_4(vcmpequh, void, env, avr, avr, avr) > DEF_HELPER_4(vcmpequw, void, env, avr, avr, avr) > DEF_HELPER_4(vcmpequd, void, env, avr, avr, avr) > +DEF_HELPER_4(vcmpnezb, void, env, avr, avr, avr) > +DEF_HELPER_4(vcmpnezh, void, env, avr, avr, avr) > +DEF_HELPER_4(vcmpnezw, void, env, avr, avr, avr) > DEF_HELPER_4(vcmpgtub, void, env, avr, avr, avr) > DEF_HELPER_4(vcmpgtuh, void, env, avr, avr, avr) > DEF_HELPER_4(vcmpgtuw, void, env, avr, avr, avr) > @@ -160,6 +163,9 @@ DEF_HELPER_4(vcmpequb_dot, void, env, avr, avr, avr) > DEF_HELPER_4(vcmpequh_dot, void, env, avr, avr, avr) > DEF_HELPER_4(vcmpequw_dot, void, env, avr, avr, avr) > DEF_HELPER_4(vcmpequd_dot, void, env, avr, avr, avr) > +DEF_HELPER_4(vcmpnezb_dot, void, env, avr, avr, avr) > +DEF_HELPER_4(vcmpnezh_dot, void, env, avr, avr, avr) > +DEF_HELPER_4(vcmpnezw_dot, void, env, avr, avr, avr) > DEF_HELPER_4(vcmpgtub_dot, void, env, avr, avr, avr) > DEF_HELPER_4(vcmpgtuh_dot, void, env, avr, avr, avr) > DEF_HELPER_4(vcmpgtuw_dot, void, env, avr, avr, avr) > diff --git a/target-ppc/int_helper.c b/target-ppc/int_helper.c > index c1b341c..bffe8d6 100644 > --- a/target-ppc/int_helper.c > +++ b/target-ppc/int_helper.c > @@ -718,6 +718,55 @@ VCMP(gtsd, >, s64) > #undef VCMP_DO > #undef VCMP > =20 > +#define VCMPNEZ_DO(suffix, element, record) \ > +void helper_vcmpnez##suffix(CPUPPCState *env, ppc_avr_t *r, \ > + ppc_avr_t *a, ppc_avr_t *b) \ > +{ \ > + uint64_t ones =3D (uint64_t)-1; = \ > + uint64_t all =3D ones; = \ > + uint64_t none =3D 0; = \ > + int i; \ > + \ > + for (i =3D 0; i < ARRAY_SIZE(r->element); i++) { = \ > + uint64_t result =3D ((a->element[i] =3D=3D 0) = \ > + || (b->element[i] =3D=3D 0) = \ > + || (a->element[i] !=3D b->element[i]) ? = \ > + ones : 0x0); > \ Couldn't you just use r->element[i] =3D result instead of the switch? > + switch (sizeof(a->element[0])) { \ > + case 8: \ > + r->u64[i] =3D result; = \ > + break; > \ Also it doesn't actually look like there is a 64-bit case. > + case 4: \ > + r->u32[i] =3D result; = \ > + break; \ > + case 2: \ > + r->u16[i] =3D result; = \ > + break; \ > + case 1: \ > + r->u8[i] =3D result; = \ > + break; \ > + } \ > + all &=3D result; = \ > + none |=3D result; = \ > + } \ > + if (record) { \ > + env->crf[6] =3D ((all !=3D 0) << 3) | ((none =3D=3D 0) << 1); = \ > + } \ > +} > + > +/* VCMPNEZ - Vector compare not equal to zero > + * suffix - instruction mnemonic suffix (b: byte, h: halfword, w: wor= d) > + * element - element type to access from vector > + */ > +#define VCMPNEZ(suffix, element) \ > + VCMPNEZ_DO(suffix, element, 0) \ > + VCMPNEZ_DO(suffix##_dot, element, 1) > +VCMPNEZ(b, u8) > +VCMPNEZ(h, u16) > +VCMPNEZ(w, u32) > +#undef VCMPNEZ_DO > +#undef VCMPNEZ > + > #define VCMPFP_DO(suffix, compare, order, record) \ > void helper_vcmp##suffix(CPUPPCState *env, ppc_avr_t *r, \ > ppc_avr_t *a, ppc_avr_t *b) \ > diff --git a/target-ppc/translate.c b/target-ppc/translate.c > index b18e13f..7cf0c8e 100644 > --- a/target-ppc/translate.c > +++ b/target-ppc/translate.c > @@ -7565,6 +7565,9 @@ GEN_VXRFORM(vcmpequb, 3, 0) > GEN_VXRFORM(vcmpequh, 3, 1) > GEN_VXRFORM(vcmpequw, 3, 2) > GEN_VXRFORM(vcmpequd, 3, 3) > +GEN_VXRFORM(vcmpnezb, 3, 4) > +GEN_VXRFORM(vcmpnezh, 3, 5) > +GEN_VXRFORM(vcmpnezw, 3, 6) > GEN_VXRFORM(vcmpgtsb, 3, 12) > GEN_VXRFORM(vcmpgtsh, 3, 13) > GEN_VXRFORM(vcmpgtsw, 3, 14) > @@ -10998,6 +11001,9 @@ GEN_VXFORM(vminfp, 5, 17), > GEN_VXRFORM(vcmpequb, 3, 0) > GEN_VXRFORM(vcmpequh, 3, 1) > GEN_VXRFORM(vcmpequw, 3, 2) > +GEN_VXRFORM(vcmpnezb, 3, 4) > +GEN_VXRFORM(vcmpnezh, 3, 5) > +GEN_VXRFORM(vcmpnezw, 3, 6) > GEN_VXRFORM(vcmpgtsb, 3, 12) > GEN_VXRFORM(vcmpgtsh, 3, 13) > GEN_VXRFORM(vcmpgtsw, 3, 14) --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --zuGyJ7KNSMOGsxcs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXmE1XAAoJEGw4ysog2bOSjLwQANmK2QasR+78eXoqsErDkbSn huya9QGB+Hhlk2AKMmA5Xh4EHfWAuXCzTgq4UGuxCBw7IPzdX+yDMHbNZ2yCUlp/ uqXcYN3epZhXSxn/oLPcW6CVQa6DPrEJM9kaAYjpwa54WcQOjzMELaa4JTa9UEDu jnlFzXLpfOnok+mCB6g0cj4sK+NzRUr9+E9zT0AFECh+qTQsmsiMGfBK8oVu14uX TM4j9D7rIzBB6bOPyPX8+xq97uAUxOEv2+WynxLbGxzOcCOJYX2U0jLD32u4MASV cHEdnQmE6UD0+lpjUNuwXqB33tzMPK3Efjk6xcUt1lgoUQVXqnMQiu9D+LeeKksQ M4pWVMdwM3qgj/BIty6tFNHvPOi+PLZo8XPLP3V6qFTaFav1ewLEclVfx0qV8uRV OfsZchpz6CZ/TnBS4KbJWLQtUsX7jZgavQ2t6lC3e+P6VvQ/YW1aJQKSp7RnCvEz XIUWsrHhAM8EH1Raif53Ot34xrikP/Y1TAqrbVRSOEE5DiFdbGFX2KJsP9tpHKjT dWQxk25ljr1JraNJBHDWYDkNyXkS/ldTbWHqx08b20GszzZ6f8Qlzwhfu7YFVOHD 7+Z2MWSzVt5S5L60rwh/AJDvcZmaS+VgxKCIQ53scUDDFz8rEEPUT+S1aVzc1+fZ R7nqHrRaz+oek6byo08K =vbFt -----END PGP SIGNATURE----- --zuGyJ7KNSMOGsxcs--