From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57104) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSI0N-0004Eo-7a for qemu-devel@nongnu.org; Wed, 27 Jul 2016 02:07:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bSI0K-0001eu-Gr for qemu-devel@nongnu.org; Wed, 27 Jul 2016 02:07:42 -0400 Date: Wed, 27 Jul 2016 16:03:14 +1000 From: David Gibson Message-ID: <20160727060314.GJ17429@voom.fritz.box> References: <1469561218-3067-1-git-send-email-nikunj@linux.vnet.ibm.com> <1469561218-3067-5-git-send-email-nikunj@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="kJCZHFqBEEYq/eA6" Content-Disposition: inline In-Reply-To: <1469561218-3067-5-git-send-email-nikunj@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH RFC v0 4/6] target-ppc: add vslv instruction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikunj A Dadhania Cc: qemu-ppc@nongnu.org, rth@twiddle.net, qemu-devel@nongnu.org, bharata@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com, benh@kernel.crashing.org, Vivek Andrew Sha --kJCZHFqBEEYq/eA6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 27, 2016 at 12:56:56AM +0530, Nikunj A Dadhania wrote: > From: Vivek Andrew Sha >=20 > vslv: Vector Shift Left Variable >=20 > Signed-off-by: Vivek Andrew Sha > Signed-off-by: Nikunj A Dadhania Reviewed-by: David Gibson > --- > target-ppc/helper.h | 1 + > target-ppc/int_helper.c | 14 ++++++++++++++ > target-ppc/translate.c | 2 ++ > 3 files changed, 17 insertions(+) >=20 > diff --git a/target-ppc/helper.h b/target-ppc/helper.h > index e93b84b..9703f85 100644 > --- a/target-ppc/helper.h > +++ b/target-ppc/helper.h > @@ -211,6 +211,7 @@ DEF_HELPER_3(vslw, void, avr, avr, avr) > DEF_HELPER_3(vsld, void, avr, avr, avr) > DEF_HELPER_3(vslo, void, avr, avr, avr) > DEF_HELPER_3(vsro, void, avr, avr, avr) > +DEF_HELPER_3(vslv, void, avr, avr, avr) > DEF_HELPER_3(vaddcuw, void, avr, avr, avr) > DEF_HELPER_3(vsubcuw, void, avr, avr, avr) > DEF_HELPER_2(lvsl, void, avr, tl) > diff --git a/target-ppc/int_helper.c b/target-ppc/int_helper.c > index bffe8d6..412398f 100644 > --- a/target-ppc/int_helper.c > +++ b/target-ppc/int_helper.c > @@ -1708,6 +1708,20 @@ VSL(w, u32, 0x1F) > VSL(d, u64, 0x3F) > #undef VSL > =20 > +void helper_vslv(ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b) > +{ > + int i; > + unsigned int shift, bytes, size; > + > + size =3D ARRAY_SIZE(r->u8); > + for (i =3D 0; i < size; i++) { > + shift =3D b->u8[i] & 0x7; /* extract shift value */ > + bytes =3D (a->u8[i] << 8) + /* extract adjacent byte= s */ > + (((i + 1) < size) ? a->u8[i + 1] : 0); > + r->u8[i] =3D (bytes << shift) >> 8; /* shift and store result = */ > + } > +} > + > void helper_vsldoi(ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b, uint32_t sh= ift) > { > int sh =3D shift & 0xf; > diff --git a/target-ppc/translate.c b/target-ppc/translate.c > index 7cf0c8e..473f21a 100644 > --- a/target-ppc/translate.c > +++ b/target-ppc/translate.c > @@ -7457,6 +7457,7 @@ GEN_VXFORM(vsraw, 2, 14); > GEN_VXFORM(vsrad, 2, 15); > GEN_VXFORM(vslo, 6, 16); > GEN_VXFORM(vsro, 6, 17); > +GEN_VXFORM(vslv, 2, 29); > GEN_VXFORM(vaddcuw, 0, 6); > GEN_VXFORM(vsubcuw, 0, 22); > GEN_VXFORM_ENV(vaddubs, 0, 8); > @@ -10942,6 +10943,7 @@ GEN_VXFORM(vsraw, 2, 14), > GEN_VXFORM_207(vsrad, 2, 15), > GEN_VXFORM(vslo, 6, 16), > GEN_VXFORM(vsro, 6, 17), > +GEN_VXFORM(vslv, 2, 29), > GEN_VXFORM(vaddcuw, 0, 6), > GEN_VXFORM(vsubcuw, 0, 22), > GEN_VXFORM(vaddubs, 0, 8), --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --kJCZHFqBEEYq/eA6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXmE6iAAoJEGw4ysog2bOSFiUQAN3bBNdfKQfbmJUkIbrbww+A TmmQ3z4fMrpxAWHGyj227m5qF4SW0iLGme+VsIE8a4PluvhYe62v5kqEEsGr7wyt Lwt5PIhL4ER1p2u1GzWRFWHhLCrVJ1Lb+EJGkLUFrmchmcUPUwxRNKo4HSy8zGg2 nABH0h/ncMrTE/xvLk2j0O8HY5in+92C4FTr7HriLB/Ilg/5HJBZCe3t7PJWU8Z1 DP/skT5oHkZ6lhoR/XMIZbw7QOiRNI80ZxU4ewffuOjkTiphp8U2P2ONOTXqXQAN +t8IBKlGUunIyRIPWTtqiVSId21a+J8YEaVXr+jMFZ73sM8eZXwuQb6agk7bdtSL a/YHz5TtEfNVukPJqJqHZPNMgn/nh57EJFtpIFPv92vC5+G8rsaEtmRVgwj1iJ6f dHxcThylCgkAazv5u5GvjvGvBnTCmufuqgoNNq3ODHwlbZwNz9rZwSGHAR+SyxF5 WnJGnLmDquikO2iC4TB18XH2if1Imp3PoB6U2KDdHo3OeMwq95E27XhURC1n06wM qWlGgmB76gi4buxdg7Awz8nQKC39d4a+phFNWuCsG/SPTUgUZTubI190TYHyxoVL Lpb156WMw9xa5HzEBfOOwmUlFBCeVNncVJLGOVZft4ucu+FYT27CagvY1zbTy+An nDwL7/c7xWafvkURBRwg =lhyZ -----END PGP SIGNATURE----- --kJCZHFqBEEYq/eA6--