From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57106) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSI0N-0004Er-9B for qemu-devel@nongnu.org; Wed, 27 Jul 2016 02:07:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bSI0K-0001f3-KB for qemu-devel@nongnu.org; Wed, 27 Jul 2016 02:07:42 -0400 Date: Wed, 27 Jul 2016 16:05:22 +1000 From: David Gibson Message-ID: <20160727060522.GK17429@voom.fritz.box> References: <1469561218-3067-1-git-send-email-nikunj@linux.vnet.ibm.com> <1469561218-3067-6-git-send-email-nikunj@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="09CsGkDdkTpDWDy8" Content-Disposition: inline In-Reply-To: <1469561218-3067-6-git-send-email-nikunj@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH RFC v0 5/6] target-ppc: add vsrv instruction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikunj A Dadhania Cc: qemu-ppc@nongnu.org, rth@twiddle.net, qemu-devel@nongnu.org, bharata@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com, benh@kernel.crashing.org, Vivek Andrew Sha --09CsGkDdkTpDWDy8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 27, 2016 at 12:56:57AM +0530, Nikunj A Dadhania wrote: > From: Vivek Andrew Sha >=20 > Adds Vector Shift Right Variable instruction. >=20 > Signed-off-by: Vivek Andrew Sha > Signed-off-by: Nikunj A Dadhania > --- > target-ppc/helper.h | 1 + > target-ppc/int_helper.c | 17 +++++++++++++++++ > target-ppc/translate.c | 2 ++ > 3 files changed, 20 insertions(+) >=20 > diff --git a/target-ppc/helper.h b/target-ppc/helper.h > index 9703f85..8eada2f 100644 > --- a/target-ppc/helper.h > +++ b/target-ppc/helper.h > @@ -211,6 +211,7 @@ DEF_HELPER_3(vslw, void, avr, avr, avr) > DEF_HELPER_3(vsld, void, avr, avr, avr) > DEF_HELPER_3(vslo, void, avr, avr, avr) > DEF_HELPER_3(vsro, void, avr, avr, avr) > +DEF_HELPER_3(vsrv, void, avr, avr, avr) > DEF_HELPER_3(vslv, void, avr, avr, avr) > DEF_HELPER_3(vaddcuw, void, avr, avr, avr) > DEF_HELPER_3(vsubcuw, void, avr, avr, avr) > diff --git a/target-ppc/int_helper.c b/target-ppc/int_helper.c > index 412398f..f4776f0 100644 > --- a/target-ppc/int_helper.c > +++ b/target-ppc/int_helper.c > @@ -1722,6 +1722,23 @@ void helper_vslv(ppc_avr_t *r, ppc_avr_t *a, ppc_a= vr_t *b) > } > } > =20 > +void helper_vsrv(ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b) > +{ > + int i; > + unsigned int shift, bytes, src[ARRAY_SIZE(r->u8) + 1]; > + > + src[0] =3D 0; > + for (i =3D 0; i < ARRAY_SIZE(r->u8); i++) { > + src[i + 1] =3D a->u8[i]; > + } > + > + for (i =3D 0; i < ARRAY_SIZE(r->u8); i++) { > + shift =3D b->u8[i] & 0x7; /* extract shift value */ > + bytes =3D (src[i] << 8) + src[i + 1]; /* extract adjacent by= tes */ I think you should be able to construct bytes on the fly without pre-generating teh whole of src, as you already did for vslv. > + r->u8[i] =3D (bytes >> shift) & 0xFF; /* shift and store resul= t */ > + } > +} > + > void helper_vsldoi(ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b, uint32_t sh= ift) > { > int sh =3D shift & 0xf; > diff --git a/target-ppc/translate.c b/target-ppc/translate.c > index 473f21a..3382cd0 100644 > --- a/target-ppc/translate.c > +++ b/target-ppc/translate.c > @@ -7457,6 +7457,7 @@ GEN_VXFORM(vsraw, 2, 14); > GEN_VXFORM(vsrad, 2, 15); > GEN_VXFORM(vslo, 6, 16); > GEN_VXFORM(vsro, 6, 17); > +GEN_VXFORM(vsrv, 2, 28); > GEN_VXFORM(vslv, 2, 29); > GEN_VXFORM(vaddcuw, 0, 6); > GEN_VXFORM(vsubcuw, 0, 22); > @@ -10943,6 +10944,7 @@ GEN_VXFORM(vsraw, 2, 14), > GEN_VXFORM_207(vsrad, 2, 15), > GEN_VXFORM(vslo, 6, 16), > GEN_VXFORM(vsro, 6, 17), > +GEN_VXFORM(vsrv, 2, 28), > GEN_VXFORM(vslv, 2, 29), > GEN_VXFORM(vaddcuw, 0, 6), > GEN_VXFORM(vsubcuw, 0, 22), --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --09CsGkDdkTpDWDy8 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXmE8iAAoJEGw4ysog2bOSLuEP/0sdn3jpOs5pN2fWxiNWec6M One3VX7tf4l5ySjtc1OJSmp+MH4MIVooQLBAIek318uOMSXwXSCUl7AMjie+b2kR A75ybQU6SRPsjT3eta8UC82RqlFXhwtNOnincNNJmnPMDEfbl1VI2WMNzfR+enEV kxSdT5+S3dYTgwwNVgyo76lz5h1C0GDRdzqPU/64yk18VF7+3GnvKbqGbBGKT0iA 5q3oRsFPX+PKd2wMLzJxygKwvly9Mw089tQQZ6VBzjV06PbpqcTIzkGlukc4OQRg nduLhNHhipsx4g4xZT5+LiH93hsyqyv+a1DCSHUcdP5FK9j3J2Y2hxnS4/1b/uDM Wv2L2Ui+sRhTZPkSv/epYabuLdYddlZ6KprTj4PWXDhnpP25vRDweEwqthwGC61b w3PJnZfNcTXFhpjkm8PXZazd9dfPb3nB9PbrPaIS8iCNhv/mj9J+9mRReHnACGsz qeQqg9Du/f7YRIoicNGxlRjAKQk8+QC2mlAyovs08Vq0FOEhJ7FS1iLS0tpR9+uD c3UI4yz55i33qwthO3urloYxx9kzI7s2i9CM7gAsIpol51wYVt2M3MihQT3iRTEI GAykMkstZHtUH50Lr4Cy9aYunMZL+P+8tX/hH0P0AAc9g0+ORcLwRq/sKc+URtaR dRSbhCsB3MULW4PK1jpO =bgO1 -----END PGP SIGNATURE----- --09CsGkDdkTpDWDy8--