From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60339) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSIJJ-00038e-Rp for qemu-devel@nongnu.org; Wed, 27 Jul 2016 02:27:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bSIJF-0006JT-Mb for qemu-devel@nongnu.org; Wed, 27 Jul 2016 02:27:17 -0400 Date: Wed, 27 Jul 2016 16:23:07 +1000 From: David Gibson Message-ID: <20160727062307.GO17429@voom.fritz.box> References: <1469534318-5549-1-git-send-email-nikunj@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="K0mDTbuGRobClnW5" Content-Disposition: inline In-Reply-To: <1469534318-5549-1-git-send-email-nikunj@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH v4 00/15] POWER9 TCG enablements - part1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikunj A Dadhania Cc: qemu-ppc@nongnu.org, rth@twiddle.net, qemu-devel@nongnu.org, bharata@linux.vnet.ibm.com, aneesh.kumar@linux.vnet.ibm.com --K0mDTbuGRobClnW5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 26, 2016 at 05:28:23PM +0530, Nikunj A Dadhania wrote: > This set starts adding new instructions for POWER9 described in ISA3.0. >=20 > Patches: > 01-02: First two patches adds the required POWER9 cpu model and ISA def= ines. > 03-14: Adds following instructions: > addpcis : Add PC Immediate Shifted > cmprb : Compare Ranged Byte > moduw : Modulo Unsigned Word > modsw : Modulo Signed Word > modud : Modulo Unsigned Dword > modsd : Modulo Signed Dword > cnttzd[.] : Count Trailing Zero Dword > cnttzw[.] : Count Trailing Zero Word > cmpeqb : Compare Equal Byte > setb : Set Boolean > maddld : Multiply-Add Low Dword > maddhd : Multiply-Add High Dword > maddhdu : Multiply-Add High Dword Unsigned > Changes following instructions: > divd[u][o][.]: Divide Doubleword Signed/Unsigned > divw[u][o][.]: Divide Word Signed/Unsigned > 15: Adds support for the new Expanded Opcode (EO) added in > ISA3.0 I've applied these to ppc-for-2.8, except for the div rework which I have a comment on, and for which I'm hoping for an R-b from rth. I did make a small tweak to 1/15. >=20 > Changelog: > v3: > * Accumulate summary overflow in place of over-writing in div[w,d] operat= ions >=20 > v2:=20 > * Implement branchless modulo instruction > * Change divd and divw to branchless implementation similar to modulo > instructions > * Drop MMU_3_00 defines from the POWER9 define until radix support is > added. >=20 > v1: > * addpcis - shift the immediate before adding > * cmprb logic without branches > * mod[su][wd]: use helpers > * cmpeqb - use bit magics in the helpers > * setb - bug fix and branchless > * maddld - discard multiple dword calculation as we need only lower 64-bit > * Expanded opcode - drop pad from 32-bit and free the third level indirec= t=20 > table in unrealize >=20 > Aneesh Kumar K.V (1): > target-ppc: Introduce Power9 family >=20 > Nikunj A Dadhania (12): > target-ppc: Introduce POWER ISA 3.0 flag > target-ppc: adding addpcis instruction > target-ppc: add cmprb instruction > target-ppc: add modulo word operations > target-ppc: add modulo dword operations > target-ppc: implement branch-less divw[o][.] > target-ppc: implement branch-less divd[o][.] > target-ppc: add cnttzw[.] instruction > target-ppc: add cmpeqb instruction > target-ppc: add maddld instruction > target-ppc: add maddhd and maddhdu instruction > target-ppc: introduce opc4 for Expanded Opcode >=20 > Sandipan Das (1): > target-ppc: add cnttzd[.] instruction >=20 > Vivek Andrew Sha (1): > target-ppc: add setb instruction >=20 > hw/ppc/spapr_cpu_core.c | 5 + > target-ppc/cpu-models.c | 5 + > target-ppc/cpu-models.h | 1 + > target-ppc/cpu-qom.h | 1 + > target-ppc/cpu.h | 5 +- > target-ppc/helper.h | 3 + > target-ppc/int_helper.c | 32 ++++ > target-ppc/mmu_helper.c | 2 +- > target-ppc/translate.c | 432 +++++++++++++++++++++++++++++++++++++-= ------ > target-ppc/translate_init.c | 212 ++++++++++++++++++---- > 10 files changed, 594 insertions(+), 104 deletions(-) >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --K0mDTbuGRobClnW5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXmFNKAAoJEGw4ysog2bOSiO0P/iVy46CzXIBFqfvC94qEa+PG VDQaBgGoAj52wsT73Kmgfp0dv2oU9Jdtt743TRNH8KgoNOQe37teLqnJgzYIfi/K 3uT49+7jSF4eYskF7EkzDpuwJipBKg/5zIGBCGRjo8sMgqECYWFBtb5MnO4Z8wzn fV5Ud8dW73Mjf1l/5PjdtwHbY55UazyTY6koLzdLTfW9xs1olEXaoKqplC6UPQL3 XUnmdyru7h/Orj6NwZxq6h46Ugiuk1Gen98IIWA4hzf9vf+UNTh+OAuA2v8WQLf3 /T1hkJ3+rB8ZY94VOs5G134JHPZD3jxihQRCpZQrm/1lPGCDm6FhUW8wHWqEVmzb tMFAnLbDkB5c2sLnGt3YF5v37imE4hPGGMio3YfeGVS2LYLpoEV/nxY4u+mGnTZb KZydCuX1YqYRFSeKlLhpurenKji1am0PbiQS8mk7SEnHNi/81ivR1cZNRLr7zZPY w8eukxP+ck+N8TqedB6IZWFjDTtSPPS2DunypEcoEY6zN/F31pvoylxtJj5DBDdt dJJns2g3LEj990lBewS4jOq9oegW4B4efW1d/0TFzWjxTpMD0v1qUJd45cM3og15 IuuQv99OvZOsqOGHvNuB4M+7fKkNWiBWKlvxe8aMUohO6qSjZTFJgAYRq3f0mSjp h9s40bGuoBHAg+fzdi3E =9oV7 -----END PGP SIGNATURE----- --K0mDTbuGRobClnW5--