Re: [Qemu-devel] [PATCH v2 2/2] util: Drop inet_listen()

["Daniel P. Berrange" <berrange@redhat.com>]

On Mon, Jul 25, 2016 at 09:02:51PM +0800, Cao jin wrote:
> Since commit e65c67e4, inet_listen() is not used anymore, and all
> inet listen operation goes through QIOChannel.
> 
> Cc: Daniel P. Berrange <berrange@redhat.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Eric Blake <eblake@redhat.com>
> 
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
>  include/qemu/sockets.h |  2 --
>  util/qemu-sockets.c    | 28 ----------------------------
>  2 files changed, 30 deletions(-)

Reviewed-by: Daniel P. Berrange <berrange@redhat.com>

> diff --git a/include/qemu/sockets.h b/include/qemu/sockets.h
> index 28a28c0..9eb2470 100644
> --- a/include/qemu/sockets.h
> +++ b/include/qemu/sockets.h
> @@ -33,8 +33,6 @@ int socket_set_fast_reuse(int fd);
>  typedef void NonBlockingConnectHandler(int fd, Error *err, void *opaque);

There's still scope for a 3rd patch to remove this NonBlockingConnectHandler
typedef, since nothing uses it anymore.


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|