From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37282) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSN8b-0007v8-BU for qemu-devel@nongnu.org; Wed, 27 Jul 2016 07:36:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bSN8X-0001Ma-7G for qemu-devel@nongnu.org; Wed, 27 Jul 2016 07:36:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41522) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSN8X-0001MW-1v for qemu-devel@nongnu.org; Wed, 27 Jul 2016 07:36:29 -0400 Date: Wed, 27 Jul 2016 12:36:25 +0100 From: "Daniel P. Berrange" Message-ID: <20160727113625.GI29546@redhat.com> Reply-To: "Daniel P. Berrange" References: <1469451771-1173-1-git-send-email-caoj.fnst@cn.fujitsu.com> <1469451771-1173-3-git-send-email-caoj.fnst@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1469451771-1173-3-git-send-email-caoj.fnst@cn.fujitsu.com> Subject: Re: [Qemu-devel] [PATCH v2 2/2] util: Drop inet_listen() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cao jin Cc: qemu-devel@nongnu.org, Gerd Hoffmann , Paolo Bonzini , Eric Blake On Mon, Jul 25, 2016 at 09:02:51PM +0800, Cao jin wrote: > Since commit e65c67e4, inet_listen() is not used anymore, and all > inet listen operation goes through QIOChannel. > > Cc: Daniel P. Berrange > Cc: Gerd Hoffmann > Cc: Paolo Bonzini > Cc: Eric Blake > > Signed-off-by: Cao jin > --- > include/qemu/sockets.h | 2 -- > util/qemu-sockets.c | 28 ---------------------------- > 2 files changed, 30 deletions(-) Reviewed-by: Daniel P. Berrange > diff --git a/include/qemu/sockets.h b/include/qemu/sockets.h > index 28a28c0..9eb2470 100644 > --- a/include/qemu/sockets.h > +++ b/include/qemu/sockets.h > @@ -33,8 +33,6 @@ int socket_set_fast_reuse(int fd); > typedef void NonBlockingConnectHandler(int fd, Error *err, void *opaque); There's still scope for a 3rd patch to remove this NonBlockingConnectHandler typedef, since nothing uses it anymore. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|