From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41426) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bSyVq-0002jV-HJ for qemu-devel@nongnu.org; Thu, 28 Jul 2016 23:31:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bSyVl-0005G6-Hj for qemu-devel@nongnu.org; Thu, 28 Jul 2016 23:31:01 -0400 Date: Fri, 29 Jul 2016 12:44:16 +1000 From: David Gibson Message-ID: <20160729024416.GF2588@voom.fritz.box> References: <1469745225.5978.236.camel@kernel.crashing.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="eDB11BtaWSyaBkpc" Content-Disposition: inline In-Reply-To: <1469745225.5978.236.camel@kernel.crashing.org> Subject: Re: [Qemu-devel] [PATCH] ppc: Some FPU helper functions must be inline List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Benjamin Herrenschmidt Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Richard Henderson --eDB11BtaWSyaBkpc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 29, 2016 at 08:33:45AM +1000, Benjamin Herrenschmidt wrote: > float_invalid_op_excp() and float_check_status() must be inline > due to their use of GETPC(). >=20 > Use __attribute__((__always_inline__)) to enforce it >=20 > Signed-off-by: Benjamin Herrenschmidt Do you want me to fold this into the patch it fixes? > --- > target-ppc/fpu_helper.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) >=20 > diff --git a/target-ppc/fpu_helper.c b/target-ppc/fpu_helper.c > index 65dc170..b0760f0 100644 > --- a/target-ppc/fpu_helper.c > +++ b/target-ppc/fpu_helper.c > @@ -117,8 +117,8 @@ void helper_compute_fprf(CPUPPCState *env, uint64_t a= rg) > } > =20 > /* Floating-point invalid operations exception */ > -static inline uint64_t float_invalid_op_excp(CPUPPCState *env, int op, > - int set_fpcc) > +static inline __attribute__((__always_inline__)) > +uint64_t float_invalid_op_excp(CPUPPCState *env, int op, int set_fpcc) > { > CPUState *cs =3D CPU(ppc_env_get_cpu(env)); > uint64_t ret =3D 0; > @@ -519,7 +519,8 @@ static void do_float_check_status(CPUPPCState *env, u= intptr_t raddr) > } > } > =20 > -static inline void float_check_status(CPUPPCState *env) > +static inline __attribute__((__always_inline__)) > +void float_check_status(CPUPPCState *env) > { > /* GETPC() works here because this is inline */ > do_float_check_status(env, GETPC()); >=20 --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --eDB11BtaWSyaBkpc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXmsMAAAoJEGw4ysog2bOSLaIP/jIVeVaDF/a41kuLQO1PYcO8 +njdtvp1UbV7pcCWQMiY39olOyvzjWnpVUFU3njypKKxf5ORVsQq0lJ7jhnA5kPA FXDBzHTL2lJ2MFKnOJP/FB1XngF2Qx+YslUMpkVjQX8pbcoFVTlYnBxDldIiLdcN QQa1CuNGX+hv30UYWpCXSLExi6mkq/ADT/NWXfbsJVELgMiXE+LzuHqq2HOKGxXU sTRYXk6BCPeyKDMFpA8+I53mUuCltsFa+qUDkUWYmze9iKK50tAyVYom7pNxs8Vm Vq3VX6ltGiHTKXfKgnxdwvpbQRZIwfFikg1JfxjgLnRU5mgsUig7YNeaH7SKBFfW zOTLbBe44ARlLkh2RVt7nqmp4KkRcNx9YUEg/8g5S5E4Wq60ccfnJvayjLwc+zCq c+Y4/N6KsbX0bFIBpyCN0WKWdSsx+SXndFAySLv5XVyGZCI2Ig/pYkevBeLJzvcH XIQcRkxvEs/dSH0k7k0+zfY5wmIMv/WKGLauxwi5E5XwMwdniujHeviOL+y9gLSm acSUHX19z3a6MX9tTz9H+U4Ay7CZ/6cVQlh43QlOJf4lXBfavRiegFzj4yakn0Uf 5JQLttObxbo8JXThCK6ujJJchKDJkLUxktgHEYMiE7Q1ea6BH4Gyu5LTZYGcjxB1 0JmHECTNfWuXb58D5DHy =0tDk -----END PGP SIGNATURE----- --eDB11BtaWSyaBkpc--