From: David Gibson <david@gibson.dropbear.id.au>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] ppc: Some FPU helper functions must be inline
Date: Fri, 29 Jul 2016 15:32:41 +1000 [thread overview]
Message-ID: <20160729053241.GQ2588@voom.fritz.box> (raw)
In-Reply-To: <1469767027.5978.242.camel@kernel.crashing.org>
[-- Attachment #1: Type: text/plain, Size: 772 bytes --]
On Fri, Jul 29, 2016 at 02:37:07PM +1000, Benjamin Herrenschmidt wrote:
> On Fri, 2016-07-29 at 12:44 +1000, David Gibson wrote:
> > On Fri, Jul 29, 2016 at 08:33:45AM +1000, Benjamin Herrenschmidt
> > wrote:
> > >
> > > float_invalid_op_excp() and float_check_status() must be inline
> > > due to their use of GETPC().
> > >
> > > Use __attribute__((__always_inline__)) to enforce it
> > >
> > > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> >
> > Do you want me to fold this into the patch it fixes?
>
> Feel free, sure
Ok, done.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-07-29 5:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 22:33 [Qemu-devel] [PATCH] ppc: Some FPU helper functions must be inline Benjamin Herrenschmidt
2016-07-29 2:44 ` David Gibson
2016-07-29 4:37 ` Benjamin Herrenschmidt
2016-07-29 5:32 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160729053241.GQ2588@voom.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=benh@kernel.crashing.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).