From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org,
Klim Kireev <proffk@virtuozzo.mipt.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/1] block/parallels: check new image size
Date: Fri, 29 Jul 2016 15:09:20 +0100 [thread overview]
Message-ID: <20160729140920.GF5443@stefanha-x1.localdomain> (raw)
In-Reply-To: <1469639300-12155-1-git-send-email-den@openvz.org>
[-- Attachment #1: Type: text/plain, Size: 871 bytes --]
On Wed, Jul 27, 2016 at 08:08:20PM +0300, Denis V. Lunev wrote:
> From: Klim Kireev <proffk@virtuozzo.mipt.com>
>
> Before this patch incorrect image could be created via qemu-img
> (Example: qemu-img create -f parallels -o size=4096T hack.img),
> incorrect images cannot be used due to overflow in main image structure.
>
> This patch add check of size in image creation.
>
> After reading size it compare it with UINT32_MAX * cluster_size.
>
> Signed-off-by: Klim Kireev <proffk@virtuozzo.mipt.com>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> changes from v1:
> - fixed from: to be virtuozzo.mipt.com to match Signed-off-by
>
> block/parallels.c | 5 +++++
> 1 file changed, 5 insertions(+)
Thanks, applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2016-07-29 14:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-27 17:08 [Qemu-devel] [PATCH v2 1/1] block/parallels: check new image size Denis V. Lunev
2016-07-29 14:09 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160729140920.GF5443@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=den@openvz.org \
--cc=proffk@virtuozzo.mipt.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).