From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45205) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bT9MT-00065I-2T for qemu-devel@nongnu.org; Fri, 29 Jul 2016 11:06:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bT9MP-0003vB-Rv for qemu-devel@nongnu.org; Fri, 29 Jul 2016 11:06:04 -0400 Received: from indium.canonical.com ([91.189.90.7]:49104) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bT9MP-0003v5-M0 for qemu-devel@nongnu.org; Fri, 29 Jul 2016 11:06:01 -0400 Received: from loganberry.canonical.com ([91.189.90.37]) by indium.canonical.com with esmtp (Exim 4.76 #1 (Debian)) id 1bT9MP-0004zH-3J for ; Fri, 29 Jul 2016 15:06:01 +0000 Received: from loganberry.canonical.com (localhost [127.0.0.1]) by loganberry.canonical.com (Postfix) with ESMTP id EDF332E80C3 for ; Fri, 29 Jul 2016 15:06:00 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Date: Fri, 29 Jul 2016 14:57:05 -0000 From: redcap97 Reply-To: Bug 1586756 <1586756@bugs.launchpad.net> Sender: bounces@canonical.com References: <20160529110018.18315.70473.malonedeb@soybean.canonical.com> Message-Id: <20160729145705.20764.81409.launchpad@wampee.canonical.com> Errors-To: bounces@canonical.com Subject: [Qemu-devel] [Bug 1586756] Re: "-serial unix:" option of qemu-system-arm is broken in qemu 2.6.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org ** Summary changed: - "-serial unix:" option of qemu-system-* is broken in qemu 2.6.0 + "-serial unix:" option of qemu-system-arm is broken in qemu 2.6.0 -- = You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1586756 Title: "-serial unix:" option of qemu-system-arm is broken in qemu 2.6.0 Status in QEMU: Incomplete Bug description: I found a bug of "-serial unix:PATH_TO_SOCKET" in qemu 2.6.0 (qemu 2.5.1 = works fine). Occasionally, a part of the output of qemu disappears in the bug. It looks like following commit is the cause: char: ensure all clients are in non-blocking mode (Author: Daniel P. Berr= ange ) http://git.qemu.org/?p=3Dqemu.git;a=3Dcommitdiff;h=3D64c800f8087485227278= 47b9cdc73412f22dffb9 In this commit, UNIX socket is set to non-blocking mode, but qemu_chr_fe_= write function doesn't handle EAGAIN. You should fix code like that: --- diff --git a/qemu-char.c b/qemu-char.c index b597ee1..0361d78 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -270,6 +270,7 @@ static int qemu_chr_fe_write_buffer(CharDriverState *= s, const uint8_t *buf, int int qemu_chr_fe_write(CharDriverState *s, const uint8_t *buf, int len) { int ret; + int offset =3D 0; = if (s->replay && replay_mode =3D=3D REPLAY_MODE_PLAY) { int offset; @@ -280,7 +281,21 @@ int qemu_chr_fe_write(CharDriverState *s, const uint= 8_t *buf, int len) } = qemu_mutex_lock(&s->chr_write_lock); - ret =3D s->chr_write(s, buf, len); + + while (offset < len) { + retry: + ret =3D s->chr_write(s, buf, len); + if (ret < 0 && errno =3D=3D EAGAIN) { + g_usleep(100); + goto retry; + } + + if (ret <=3D 0) { + break; + } + + offset +=3D ret; + } = if (ret > 0) { qemu_chr_fe_write_log(s, buf, ret); --- Or please do "git revert 64c800f808748522727847b9cdc73412f22dffb9". To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1586756/+subscriptions