From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60710) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bTitV-0003g2-Ia for qemu-devel@nongnu.org; Sun, 31 Jul 2016 01:02:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bTitQ-0001XP-Lc for qemu-devel@nongnu.org; Sun, 31 Jul 2016 01:02:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41992) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bTitQ-0001XJ-Fr for qemu-devel@nongnu.org; Sun, 31 Jul 2016 01:02:28 -0400 Date: Sun, 31 Jul 2016 08:02:22 +0300 From: "Michael S. Tsirkin" Message-ID: <20160729211011-mutt-send-email-mst@kernel.org> References: <1469800542-11402-1-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1469800542-11402-1-git-send-email-imammedo@redhat.com> Subject: Re: [Qemu-devel] [PATCH for-2.7] apic: fix broken migration for kvm-apic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, ehabkost@redhat.com, pbonzini@redhat.com, dgilbert@redhat.com, peter.maydell@linaro.org On Fri, Jul 29, 2016 at 03:55:42PM +0200, Igor Mammedov wrote: > commit f6e98444 (apic: Use apic_id as apic's migration instance_id) > breaks migration when in kernel irqchip is used for 2.6 and older > machine types. > > It applies compat property only for userspace 'apic' type > instead of applying it to all apic types inherited from > 'apic-common' type as it was supposed to do. > > Fix it by setting compat property 'legacy-instance-id' for > 'apic-common' type which affects inherited types (i.e. not > only 'apic' but also 'kvm-apic' types) > > Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin > --- > include/hw/i386/pc.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h > index c87c5c1..74c175c 100644 > --- a/include/hw/i386/pc.h > +++ b/include/hw/i386/pc.h > @@ -388,7 +388,7 @@ bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *); > .value = "off",\ > },\ > {\ > - .driver = "apic",\ > + .driver = "apic-common",\ > .property = "legacy-instance-id",\ > .value = "on",\ > }, > -- > 2.7.4