From: David Gibson <david@gibson.dropbear.id.au>
To: alarson@ddci.com
Cc: agraf@suse.de, qemu-devel@nongnu.org, qemu-ppc@nongnu.org
Subject: Re: [Qemu-devel] target-ppc: SPR_BOOKE_ESR not set on FP exceptions
Date: Mon, 1 Aug 2016 14:35:43 +1000 [thread overview]
Message-ID: <20160801043543.GW2588@voom.fritz.box> (raw)
In-Reply-To: <OFE8303EB4.3E78490C-ON86257FFF.00474BB9-86257FFF.0047C8F7@ddci.com>
[-- Attachment #1: Type: text/plain, Size: 1237 bytes --]
On Fri, Jul 29, 2016 at 08:04:04AM -0500, alarson@ddci.com wrote:
> David Gibson <david@gibson.dropbear.id.au> wrote on 07/29/2016 12:40:15
> AM:
>
> > From: David Gibson <david@gibson.dropbear.id.au>
> > To: alarson@ddci.com
> > Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, agraf@suse.de
> > Date: 07/29/2016 12:38 AM
> > Subject: Re: target-ppc: SPR_BOOKE_ESR not set on FP exceptions
> >
> > On Thu, Jul 28, 2016 at 06:32:27PM -0500, alarson@ddci.com wrote:
> ...
> > > I did a quick check of the bits set in the POWERPC_EXCP_PROGRAM case.
> > > The classic PPC sets SRR1 bits 11--15 depending on the exception. In
> > > Book E these correspond to bits 43--47,
> >
> > Um.. what? I'm not understanding where this bit shift is coming
> > from.
>
> Sorry, I was looking at an old "classic" 32-bit manual for the SRR1
> exception definition and a 64-bit manual for the BookE. They are
> the same bits. MSB0 bit numbering bytes again :-)
Ok. Can you re-do your analysis and submit a patch to fix this?
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-08-01 4:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-28 23:32 [Qemu-devel] target-ppc: SPR_BOOKE_ESR not set on FP exceptions alarson
2016-07-29 5:40 ` David Gibson
2016-07-29 13:04 ` alarson
2016-08-01 4:35 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160801043543.GW2588@voom.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.de \
--cc=alarson@ddci.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).