From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54332)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bUOCm-0007HP-Fa
	for qemu-devel@nongnu.org; Mon, 01 Aug 2016 21:09:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1bUOCj-0002Sy-9j
	for qemu-devel@nongnu.org; Mon, 01 Aug 2016 21:09:12 -0400
Date: Tue, 2 Aug 2016 09:09:06 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20160802010906.GA680@ad.usersys.redhat.com>
References: <1470027888-24381-1-git-send-email-famz@redhat.com>
	<abd48ab4-4fd2-9e5e-c680-cbac5396f594@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <abd48ab4-4fd2-9e5e-c680-cbac5396f594@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] curl: Cast fd to int for DPRINTF
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: John Snow <jsnow@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, QEMU Trivial <qemu-trivial@nongnu.org>

On Mon, 08/01 12:41, John Snow wrote:
> > -    DPRINTF("CURL (AIO): Sock action %d on fd %d\n", action, fd);
> > +    DPRINTF("CURL (AIO): Sock action %d on fd %d\n", action, (int)fd);
> >      switch (action) {
> >          case CURL_POLL_IN:
> >              aio_set_fd_handler(s->aio_context, fd, false,
> > 
> 
> Is curl_socket_t always of type long long unsigned int? why not use %llu ?

Since it is a typedef, variation between platforms is imaginable. On Linux it
is 4 bytes, the error is only seen on Windows.

Fam