[Qemu-devel] [PATCH] virtio-blk: Remove stale comment about draining

[Qemu-devel] [PATCH] virtio-blk: Remove stale comment about draining

[Fam Zheng]

This is stale after commit 6e40b3bf (virtio-blk: Use blk_drain() to
drain IO requests), remove it.

Suggested-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
---
 hw/block/virtio-blk.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index 89eca65..3468a21 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -656,10 +656,6 @@ static void virtio_blk_reset(VirtIODevice *vdev)
     AioContext *ctx;
     VirtIOBlockReq *req;
 
-    /*
-     * This should cancel pending requests, but can't do nicely until there
-     * are per-device request lists.
-     */
     ctx = blk_get_aio_context(s->blk);
     aio_context_acquire(ctx);
     while (s->rq) {
-- 
2.7.4

Re: [Qemu-devel] [PATCH] virtio-blk: Remove stale comment about draining

[Fam Zheng]

On Mon, 08/01 10:53, Fam Zheng wrote:
> This is stale after commit 6e40b3bf (virtio-blk: Use blk_drain() to
> drain IO requests), remove it.
> 
> Suggested-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---

Forgot to say, this applies on top of

[Qemu-devel] [PATCH] virtio-blk: Release s->rq queue at system_reset

which affects the diff's context slightly.

Fam

Re: [Qemu-devel] [PATCH] virtio-blk: Remove stale comment about draining

[Laszlo Ersek]

On 08/01/16 04:53, Fam Zheng wrote:
> This is stale after commit 6e40b3bf (virtio-blk: Use blk_drain() to
> drain IO requests), remove it.
> 
> Suggested-by: Laszlo Ersek <lersek@redhat.com>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  hw/block/virtio-blk.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
> index 89eca65..3468a21 100644
> --- a/hw/block/virtio-blk.c
> +++ b/hw/block/virtio-blk.c
> @@ -656,10 +656,6 @@ static void virtio_blk_reset(VirtIODevice *vdev)
>      AioContext *ctx;
>      VirtIOBlockReq *req;
>  
> -    /*
> -     * This should cancel pending requests, but can't do nicely until there
> -     * are per-device request lists.
> -     */
>      ctx = blk_get_aio_context(s->blk);
>      aio_context_acquire(ctx);
>      while (s->rq) {
> 

The thing I mildly dislike about patches that consist purely of code
removal is that they don't show up in "git blame", so it's hard to get
credit for them :) Which is a shame, beacuse code deletion is the best
kind of patch! :)

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Cheers!
Laszlo

Re: [Qemu-devel] [PATCH] virtio-blk: Remove stale comment about draining

[Fam Zheng]

On Mon, 08/01 15:45, Laszlo Ersek wrote:
> The thing I mildly dislike about patches that consist purely of code
> removal is that they don't show up in "git blame", so it's hard to get
> credit for them :) Which is a shame, beacuse code deletion is the best
> kind of patch! :)

I can't agree more!  Thanks for reviewing!

Fam