From: Peter Xu <peterx@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org,
pbonzini@redhat.com, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3] x86: ioapic: add support for explicit EOI
Date: Tue, 2 Aug 2016 10:50:16 +0800 [thread overview]
Message-ID: <20160802025016.GF6207@pxdev.xzpeter.org> (raw)
In-Reply-To: <20160801164326.7d9b962f@nial.brq.redhat.com>
On Mon, Aug 01, 2016 at 04:43:26PM +0200, Igor Mammedov wrote:
> > One thing to mention: this patch only applies to emulated IOAPIC. It
> > does not affect kernel IOAPIC behavior.
> ^^^ which is .... ?
What I wanted to express is that this property will not taking effect
when kernel ioapic is used (so kernel IOAPIC will still have version
0x11). However after a second thought I think this sentence can be
removed as well, since we are using "kvm-ioapic" device for kernel
IOAPIC, and property name "ioapic.version" should explain itself
already. :)
Thanks for review,
-- peterx
next prev parent reply other threads:[~2016-08-02 2:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 13:59 [Qemu-devel] [PATCH v3] x86: ioapic: add support for explicit EOI Peter Xu
2016-08-01 14:43 ` Igor Mammedov
2016-08-01 14:45 ` Paolo Bonzini
2016-08-02 2:50 ` Peter Xu [this message]
2016-08-01 14:56 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160802025016.GF6207@pxdev.xzpeter.org \
--to=peterx@redhat.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).