From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39210) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUPmj-0001P6-KV for qemu-devel@nongnu.org; Mon, 01 Aug 2016 22:50:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bUPmf-0003UN-Fy for qemu-devel@nongnu.org; Mon, 01 Aug 2016 22:50:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38202) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUPmf-0003UJ-A1 for qemu-devel@nongnu.org; Mon, 01 Aug 2016 22:50:21 -0400 Date: Tue, 2 Aug 2016 10:50:16 +0800 From: Peter Xu Message-ID: <20160802025016.GF6207@pxdev.xzpeter.org> References: <1470059959-372-1-git-send-email-peterx@redhat.com> <20160801164326.7d9b962f@nial.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160801164326.7d9b962f@nial.brq.redhat.com> Subject: Re: [Qemu-devel] [PATCH v3] x86: ioapic: add support for explicit EOI List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org, pbonzini@redhat.com, mst@redhat.com On Mon, Aug 01, 2016 at 04:43:26PM +0200, Igor Mammedov wrote: > > One thing to mention: this patch only applies to emulated IOAPIC. It > > does not affect kernel IOAPIC behavior. > ^^^ which is .... ? What I wanted to express is that this property will not taking effect when kernel ioapic is used (so kernel IOAPIC will still have version 0x11). However after a second thought I think this sentence can be removed as well, since we are using "kvm-ioapic" device for kernel IOAPIC, and property name "ioapic.version" should explain itself already. :) Thanks for review, -- peterx