From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41187)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dahi@linux.vnet.ibm.com>) id 1bUZJg-0007tq-Ms
	for qemu-devel@nongnu.org; Tue, 02 Aug 2016 09:01:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dahi@linux.vnet.ibm.com>) id 1bUZJc-0006Wt-U2
	for qemu-devel@nongnu.org; Tue, 02 Aug 2016 09:01:04 -0400
Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:46746)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dahi@linux.vnet.ibm.com>) id 1bUZJc-0006Wg-KR
	for qemu-devel@nongnu.org; Tue, 02 Aug 2016 09:01:00 -0400
Received: from pps.filterd (m0098404.ppops.net [127.0.0.1])
	by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id
	u72D072i108052
	for <qemu-devel@nongnu.org>; Tue, 2 Aug 2016 09:00:59 -0400
Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103])
	by mx0a-001b2d01.pphosted.com with ESMTP id 24graw4tpr-1
	(version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT)
	for <qemu-devel@nongnu.org>; Tue, 02 Aug 2016 09:00:59 -0400
Received: from localhost
	by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <dahi@linux.vnet.ibm.com>;
	Tue, 2 Aug 2016 14:00:56 +0100
Received: from b06cxnps3074.portsmouth.uk.ibm.com
	(d06relay09.portsmouth.uk.ibm.com [9.149.109.194])
	by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id E9A56219005F
	for <qemu-devel@nongnu.org>; Tue,  2 Aug 2016 14:00:19 +0100 (BST)
Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com
	[9.149.37.212])
	by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id u72D0rmY24576246
	for <qemu-devel@nongnu.org>; Tue, 2 Aug 2016 13:00:53 GMT
Received: from d06av01.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av01.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id u72D0rxC027449
	for <qemu-devel@nongnu.org>; Tue, 2 Aug 2016 07:00:53 -0600
Date: Tue, 2 Aug 2016 15:00:51 +0200
From: David Hildenbrand <dahi@linux.vnet.ibm.com>
In-Reply-To: <18a1c449-bfc9-df6f-a545-4fb0d32b39ff@redhat.com>
References: <1470139155-53900-1-git-send-email-dahi@linux.vnet.ibm.com>
	<1470139155-53900-16-git-send-email-dahi@linux.vnet.ibm.com>
	<18a1c449-bfc9-df6f-a545-4fb0d32b39ff@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Message-Id: <20160802150051.2eb38191@thinkpad-w530>
Subject: Re: [Qemu-devel] [Patch v1 15/29] s390x/sclp: indicate sclp features
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, ehabkost@redhat.com, borntraeger@de.ibm.com, fiuczy@linux.vnet.ibm.com, cornelia.huck@de.ibm.com, imammedo@redhat.com, jdenemar@redhat.com, mimu@linux.vnet.ibm.com


> > +void s390_get_feat_block(S390FeatType type, uint8_t *data)
> > +{
> > +    static S390CPU *cpu;
> > +
> > +    if (!cpu) {
> > +        cpu = S390_CPU(qemu_get_cpu(0));
> > +    }
> > +
> > +    if (!cpu || !cpu->model) {
> > +        return;
> > +    }
> > +    return s390_fill_feat_block(cpu->model->features, type, data);  
> 
> IMHO it's somewhat strange to write "return something()" in a function
> that has been declared as "void". I know GCC does not reject this, but
> anyway, I'd suggest to simply remove the "return" keyword here.
> 
>  Thomas

Yes, that looks like a leftover, thanks Thomas!

David